Re: [Qemu-devel] [usb] call destroy for usb devices upon removal from guest

2006-07-18 Thread Lonnie Mendez
On Tue, 2006-07-18 at 23:46 +0200, Fabrice Bellard wrote: > Lonnie Mendez wrote: > > lo list. I have found the old diff to be incorrect on many levels. New > > diff has additionally cleanup code for the linux redirector. Please see > > the attached patch for solution. > > Forget my last comment

Re: [Qemu-devel] [usb] call destroy for usb devices upon removal from guest

2006-07-18 Thread Fabrice Bellard
Lonnie Mendez wrote: lo list. I have found the old diff to be incorrect on many levels. New diff has additionally cleanup code for the linux redirector. Please see the attached patch for solution. Forget my last comment - I understand the problem now. I think it was a bad idea to use 'usb_r

Re: [Qemu-devel] [usb] call destroy for usb devices upon removal from guest

2006-07-18 Thread Fabrice Bellard
Hi, Calling dev->handle_reset() is redundant with usb_attach(port, NULL) and is also incorrect because dev->handle_reset is a private helper for the usb devices (the real message is USB_DETACH). Regards, Fabrice. Lonnie Mendez wrote: lo list. I have found the old diff to be incorrect on m

Re: [Qemu-devel] [usb] call destroy for usb devices upon removal from guest

2006-07-17 Thread Lonnie Mendez
lo list. I have found the old diff to be incorrect on many levels. New diff has additionally cleanup code for the linux redirector. Please see the attached patch for solution. --- qemu/vl.c 2006-07-17 03:16:38.191157512 -0500 +++ qemu/vl.c 2006-07-17 03:18:13.402683160 -0500 @@ -3781,6 +3781,7 @

[Qemu-devel] [usb] call destroy for usb devices upon removal from guest

2006-05-26 Thread Lonnie Mendez
lo list. The attached patch calls the cleanup message destroy when the device is detached by the user from the guest. --- qemu/hw/usb-hub.c 2006-05-25 18:58:51.0 -0500 +++ qemu/hw/usb-hub.c 2006-05-26 16:47:47.0 -0500 @@ -194,7 +194,6 @@ /* send the detach messa