Re: [Qemu-devel] [sheepdog] [PATCH v3] sheepdog: fix loadvm operation

2013-04-25 Thread Liu Yuan
On 04/25/2013 06:03 PM, MORITA Kazutaka wrote: > The block driver tries to delete the vdi, but the sheepdog servers > return "No such vdi" - I thought that something goes wrong in this > case. > > What's the scenario where the sheepdog servers return SD_RES_NO_VDI? > Can we ignore it safely? V2 h

Re: [Qemu-devel] [sheepdog] [PATCH v3] sheepdog: fix loadvm operation

2013-04-25 Thread MORITA Kazutaka
At Thu, 25 Apr 2013 17:44:41 +0800, Liu Yuan wrote: > > On 04/25/2013 05:40 PM, MORITA Kazutaka wrote: > > Isn't it better to show an error message when the result code is > > SD_RES_NO_VDI? > > This information isn't useful even for debugging, what it for? The block driver tries to delete the v

Re: [Qemu-devel] [sheepdog] [PATCH v3] sheepdog: fix loadvm operation

2013-04-25 Thread Liu Yuan
On 04/25/2013 05:40 PM, MORITA Kazutaka wrote: > Isn't it better to show an error message when the result code is > SD_RES_NO_VDI? This information isn't useful even for debugging, what it for? Thanks, Yuan

Re: [Qemu-devel] [sheepdog] [PATCH v3] sheepdog: fix loadvm operation

2013-04-25 Thread MORITA Kazutaka
At Thu, 25 Apr 2013 16:42:34 +0800, Liu Yuan wrote: > > +/* Delete current working VDI on the snapshot chain */ > +static bool sd_delete(BDRVSheepdogState *s) > +{ > +unsigned int wlen = SD_MAX_VDI_LEN, rlen = 0; > +SheepdogVdiReq hdr = { > +.opcode = SD_OP_DEL_VDI, > +.vdi