Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-17 Thread Kevin Wolf
Am 16.05.2011 18:26, schrieb Paolo Bonzini: > On 05/16/2011 05:58 PM, Kevin Wolf wrote: >> Thanks. Still doesn't make much sense to me, the patch shouldn't change >> anything with respect to a malloc, but I can reproduce a segfault now. I >> think I'll have a closer look tomorrow. > > This fixes i

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Paolo Bonzini wrote: > This fixes it on top of my SCSI refactoring series. Thanks! Works here, too, for what it's worth. I squashed the following in when applying the "scsi: introduce scsi_req_cancel" patch, for easier reading and to get a little closer to warning-free compilation with gcc 4.6.

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 05:58 PM, Kevin Wolf wrote: > Thanks. Still doesn't make much sense to me, the patch shouldn't change > anything with respect to a malloc, but I can reproduce a segfault now. I > think I'll have a closer look tomorrow. This fixes it on top of my SCSI refactoring series. Should I sen

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Kevin Wolf
Am 16.05.2011 17:43, schrieb Jonathan Nieder: > Kevin Wolf wrote: > >> Your instructions seemed clear enough, so I tried to reproduce your >> problem. Now I have an ARM VM with a Debian installation that works just >> fine and I have no idea what to use it for. ;-) > > So I was puzzled about this

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Kevin Wolf wrote: > Your instructions seemed clear enough, so I tried to reproduce your > problem. Now I have an ARM VM with a Debian installation that works just > fine and I have no idea what to use it for. ;-) So I was puzzled about this for a while, but then I had a flash of inspiration:

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Kevin Wolf wrote: > I also reviewed the patch that you mentioned and I can't find anything > suspicious there. I'm afraid you'll have to bite the bullet and run it > with some debugging code yourself (if it's really related to that patch, > you'll want to enable DPRINTF in hw/scsi-disk.c as a firs

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Kevin Wolf
Hi Jonathan, Am 16.05.2011 13:23, schrieb Jonathan Nieder: > Hi, > > Kevin Wolf wrote: > >> This pulls the request completion for error cases from the caller to >> scsi_disk_emulate_command. This should not change semantics, but allows to >> reuse scsi_handle_write_error() for flushes in the nex

[Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Hi, Kevin Wolf wrote: > This pulls the request completion for error cases from the caller to > scsi_disk_emulate_command. This should not change semantics, but allows to > reuse scsi_handle_write_error() for flushes in the next patch. Today I tried out qemu-system-arm for the first time. It's f