Re: [Qemu-devel] [patch 4/4] QEMU live block copy

2011-06-16 Thread Stefan Hajnoczi
On Wed, Jun 15, 2011 at 6:14 PM, Marcelo Tosatti wrote: A couple of comments, nothing critical. Rest of the series looks good. Bulk phase is really the dirty phase with all blocks starting dirty (except !bdrv_is_allocate() blocks cleared if shared source). There may not be much benefit in unify

Re: [Qemu-devel] [patch 4/4] QEMU live block copy

2011-06-16 Thread Jiri Denemark
On Wed, Jun 15, 2011 at 14:14:07 -0300, Marcelo Tosatti wrote: > Index: qemu-block-copy/qmp-commands.hx > === > --- qemu-block-copy.orig/qmp-commands.hx > +++ qemu-block-copy/qmp-commands.hx ... > SQMP > +query-block-copy > +-

[Qemu-devel] [patch 4/4] QEMU live block copy

2011-06-15 Thread Marcelo Tosatti
Support live image copy + switch. That is, copy an image backing a guest hard disk to a destination image (destination image must be created separately), and switch to this copy. Command syntax: block_copy device filename [-i] -- live block copy device to image -i for incremental cop