Re: [Qemu-devel] [libvirt] [PATCH] snapshot: fix rollback failure in transaction mode

2012-09-12 Thread Guannan Ren
On 09/13/2012 01:47 AM, Eric Blake wrote: On 09/12/2012 09:22 AM, Guannan Ren wrote: After failure of qemu transaction command, the snapshot file still be there with non-zero in size. In order to unlink the file, the patch removes the file size checking. Can you give some exact steps to reprodu

Re: [Qemu-devel] [libvirt] [PATCH] snapshot: fix rollback failure in transaction mode

2012-09-12 Thread Eric Blake
On 09/12/2012 12:33 PM, Jeff Cody wrote: > If QEMU creates the snapshot file, upon transaction failure it is > possible to have a newly created image file left, depending on when the > failure occurs. The running QEMU instance, however, will not be > affected. > > For instance, if we are perform

Re: [Qemu-devel] [libvirt] [PATCH] snapshot: fix rollback failure in transaction mode

2012-09-12 Thread Jeff Cody
On 09/12/2012 01:47 PM, Eric Blake wrote: > On 09/12/2012 09:22 AM, Guannan Ren wrote: >> After failure of qemu transaction command, the snapshot file still >> be there with non-zero in size. In order to unlink the file, the >> patch removes the file size checking. > > Can you give some exact step

Re: [Qemu-devel] [libvirt] [PATCH] snapshot: fix rollback failure in transaction mode

2012-09-12 Thread Eric Blake
On 09/12/2012 09:22 AM, Guannan Ren wrote: > After failure of qemu transaction command, the snapshot file still > be there with non-zero in size. In order to unlink the file, the > patch removes the file size checking. Can you give some exact steps to reproduce this, so that I know who is making t