Re: [Qemu-devel] [for-2.9 4/8] block: Document -drive problematic code and bugs

2017-03-30 Thread Max Reitz
On 30.03.2017 16:42, Markus Armbruster wrote: > Eric Blake writes: > >> On 03/30/2017 01:52 AM, Markus Armbruster wrote: >> > +++ b/block.c > @@ -1157,6 +1157,12 @@ static int bdrv_open_common(BlockDriverState *bs, > BlockBackend *file, > if (file != NULL) { > f

Re: [Qemu-devel] [for-2.9 4/8] block: Document -drive problematic code and bugs

2017-03-30 Thread Markus Armbruster
Eric Blake writes: > On 03/30/2017 01:52 AM, Markus Armbruster wrote: > +++ b/block.c @@ -1157,6 +1157,12 @@ static int bdrv_open_common(BlockDriverState *bs, BlockBackend *file, if (file != NULL) { filename = blk_bs(file)->filename; } else {

Re: [Qemu-devel] [for-2.9 4/8] block: Document -drive problematic code and bugs

2017-03-30 Thread Eric Blake
On 03/30/2017 01:52 AM, Markus Armbruster wrote: >>> +++ b/block.c >>> @@ -1157,6 +1157,12 @@ static int bdrv_open_common(BlockDriverState *bs, >>> BlockBackend *file, >>> if (file != NULL) { >>> filename = blk_bs(file)->filename; >>> } else { >>> + /* >>> +* Caut

Re: [Qemu-devel] [for-2.9 4/8] block: Document -drive problematic code and bugs

2017-03-29 Thread Markus Armbruster
Max Reitz writes: > On 29.03.2017 18:45, Markus Armbruster wrote: >> -blockdev and blockdev_add convert their arguments via QObject to >> BlockdevOptions for qmp_blockdev_add(), which converts them back to >> QObject, then to a flattened QDict. The QDict's members are typed >> according to the Q

Re: [Qemu-devel] [for-2.9 4/8] block: Document -drive problematic code and bugs

2017-03-29 Thread Max Reitz
On 29.03.2017 18:45, Markus Armbruster wrote: > -blockdev and blockdev_add convert their arguments via QObject to > BlockdevOptions for qmp_blockdev_add(), which converts them back to > QObject, then to a flattened QDict. The QDict's members are typed > according to the QAPI schema. > > -drive co

[Qemu-devel] [for-2.9 4/8] block: Document -drive problematic code and bugs

2017-03-29 Thread Markus Armbruster
-blockdev and blockdev_add convert their arguments via QObject to BlockdevOptions for qmp_blockdev_add(), which converts them back to QObject, then to a flattened QDict. The QDict's members are typed according to the QAPI schema. -drive converts its argument via QemuOpts to a (flat) QDict. This