Re: [Qemu-devel] [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

2016-07-22 Thread Emil Condrea
Sure, I will continue to send revisions until it is approved upstream. On Jul 22, 2016 5:24 PM, "Quan Xu" wrote: > Anthony, thanks for your explaination. > IMO, patch 1 and patch 2 need your detailed review.. IMO the reset > patches are good in general.. > Emil, if patch 1 / patch 2 are reviewed

Re: [Qemu-devel] [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

2016-07-22 Thread Quan Xu
Anthony, thanks for your explaination.IMO, patch 1  and patch 2 need your detailed review.. IMO the reset patches are good in general..Emil, if patch 1 / patch 2 are reviewed from anthony, could you send out v10? :) i know it's not an easy task, thanks in advence!! Quan On Mon, 18 Jul 2016 15:5

Re: [Qemu-devel] [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

2016-07-22 Thread Quan Xu
    sorry for the bad format from web email, and later review (neo training in new company)..    patch 6 -- patch 12, rename * patch,  are good to me.  Quan   --From:Emil Condrea Time:2016 Jul 19 (Tue) 00:54To:Eric Blake Cc:qemu-d

Re: [Qemu-devel] [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

2016-07-18 Thread Emil Condrea
Eric, this is the link to the original patch which is well formatted: http://marc.info/?l=xen-devel&m=146815138831762&w=2 I think that the formatting and s-o-b was broken in the reply from Quan. On Jul 18, 2016 17:57, "Eric Blake" wrote: > On 07/17/2016 01:41 AM, Quan Xu wrote: > > > > [Quan:]:

Re: [Qemu-devel] [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

2016-07-18 Thread Eric Blake
On 07/17/2016 01:41 AM, Quan Xu wrote: > > [Quan:]: comment starts with [Quan:] > This line doesn't belong in a commit message; it's fine to put it after the --- separator though, if it aids mailing list reviewers. > > The purpose of the new file is to store generic functions shared by > fron

Re: [Qemu-devel] [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

2016-07-18 Thread Anthony PERARD
On Sun, Jul 17, 2016 at 03:41:26PM +0800, Quan Xu wrote: > > [Quan:]: comment starts with [Quan:] > > > The purpose of the new file is to store generic functions shared by  > frontendand backends such as xenstore operations, xendevs. > > Signed-off-by: Quan Xu  > Signed-off-by: Emil Condrea  >

Re: [Qemu-devel] [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

2016-07-17 Thread Emil Condrea
On Jul 17, 2016 10:41, "Quan Xu" wrote: > > > [Quan:]: comment starts with [Quan:] > Thanks, Quan for your comments. The first patches from this series just move some code from xen_backend to xen_pvdev file. I would not group the reorg from xen_backend with refactoring in the same patch. Eventual

Re: [Qemu-devel] [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

2016-07-17 Thread Quan Xu
[Quan:]: comment starts with [Quan:] The purpose of the new file is to store generic functions shared by frontendand  backends such as xenstore operations, xendevs. Signed-off-by: Quan Xu  Signed-off-by: Emil Condrea  ---  hw/xen/Makefile.objs |   2 +-  hw/xen/xen_backend.c | 12