Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-03 Thread James Bulpin
On Tue, 2013-07-02 at 10:05, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell > > Sent: 02 July 2013 10:02 > > To: Paul Durrant > > Cc: Jan Beulich; qemu-devel@nongnu.org; xen-de...@lists.xen.org > > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > > > On Tue, 2013

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Ian Campbell
On Wed, 2013-07-03 at 08:45 -0500, Anthony Liguori wrote: > Ian Campbell writes: > > > On Wed, 2013-07-03 at 09:34 +0100, Paul Durrant wrote: > >> Already did that :-) > >> > >> > There are also sub-vendor and sub-device IDs but I don't think they are > >> > so useful for us (AFAIK they are int

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Anthony Liguori
Ian Campbell writes: > On Wed, 2013-07-03 at 09:34 +0100, Paul Durrant wrote: >> Already did that :-) >> >> > There are also sub-vendor and sub-device IDs but I don't think they are >> > so useful for us (AFAIK they are intended to allow the board >> > manufacturer to "subclass" the IDs baked i

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 03 July 2013 11:50 > To: Paul Durrant > Cc: Stefano Stabellini; qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: RE: [Xen-devel] [PATCH] Citrix PV Bus device [V3] > > On Wed, 3 Jul 20

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Stefano Stabellini
On Wed, 3 Jul 2013, Paul Durrant wrote: > > - the Citrix [vendor id|device id] pair has to be different from the > > xenproject one (0x5853|0x0001). I am sure we can arrange the > > xenproject device id space so that Windows PV drivers vendors don't have > > to acquire their own PCI vendor ids. > >

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Ian Campbell
On Wed, 2013-07-03 at 09:34 +0100, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell > > Sent: 03 July 2013 09:29 > > To: Stefano Stabellini > > Cc: Paolo Bonzini; Paul Durrant; qemu-devel@nongnu.org; Anthony Liguori; > > xen-de...@lists.xen.org > > Subject: Re: [Xen-devel]

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 03 July 2013 09:29 > To: Stefano Stabellini > Cc: Paolo Bonzini; Paul Durrant; qemu-devel@nongnu.org; Anthony Liguori; > xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [Qemu-devel] [PATCH] Citrix PV Bus device [V3] > > On Tue, 2013-07-0

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Ian Campbell
On Tue, 2013-07-02 at 19:05 +0100, Stefano Stabellini wrote: > On Tue, 2 Jul 2013, Stefano Stabellini wrote: > > - the new device should have configurable vendor and device ids, so that > > host admins can select which vendor's PV drivers are going to be > > automatically installed on all your Wind

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 02 July 2013 17:42 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device [V3] > > On Tue, 2 Jul 2013, Paul Durrant wro

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-02 Thread Anthony Liguori
Stefano Stabellini writes: > On Tue, 2 Jul 2013, Stefano Stabellini wrote: >> - the new device should have configurable vendor and device ids, so that >> host admins can select which vendor's PV drivers are going to be >> automatically installed on all your Windows guests. This should probably >>

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-02 Thread Stefano Stabellini
On Tue, 2 Jul 2013, Stefano Stabellini wrote: > - the new device should have configurable vendor and device ids, so that > host admins can select which vendor's PV drivers are going to be > automatically installed on all your Windows guests. This should probably > be a VM config option (pvdevice=,

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-02 Thread Stefano Stabellini
On Tue, 2 Jul 2013, Paul Durrant wrote: > This patch introduces a new PCI device which will act as the binding point > for Citrix branded PV drivers for Xen. > The intention is that Citrix Windows PV drivers will be available on Windows > Update and thus using the existing Xen platform PCI device a

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Alex Bligh
Ian, --On 2 July 2013 14:42:41 +0100 Ian Campbell wrote: Let's say we do this, then Xirtic also produce PV drivers, and get assigned their own device ID. Will both of them be visible with a different device ID for the same device? Different device ID for the same device isn't possible, a d

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 15:08 +0100, Paul Durrant wrote: > > -Original Message- > > > > FWIW I don't think QEMU should be the registry of these device IDs. Can > > you create a file somewhere in the Xen source base to serve as the > > registry, probably somewhere under xen/include/public. >

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
> -Original Message- > > FWIW I don't think QEMU should be the registry of these device IDs. Can > you create a file somewhere in the Xen source base to serve as the > registry, probably somewhere under xen/include/public. > Is the Xen source base actually the right place? The vendor ID

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 02 July 2013 14:43 > To: Paul Durrant > Cc: Tim (Xen.org); qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > On Tue, 2013-07-02 at 13:51 +0100, Paul Durrant wrote: > > Yes, that makes

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 13:51 +0100, Paul Durrant wrote: > Yes, that makes sense *but* I would still like to avoid carrying a > private patch to QEMU (and potentially have to keep rebasing it), It's small and pretty self contained I think. Someone (Anthony?) recommended making it subclass the exist

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 14:36 +0100, Alex Bligh wrote: > > --On 2 July 2013 13:43:38 +0100 Ian Campbell > wrote: > > > We assign a device ID to your drivers (and we would do the same for any > > vendor). You can then upload drivers supporting that ID to WU and > > arrange within your product to c

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Alex Bligh
--On 2 July 2013 13:43:38 +0100 Ian Campbell wrote: We assign a device ID to your drivers (and we would do the same for any vendor). You can then upload drivers supporting that ID to WU and arrange within your product to create the appropriate device. Let's say we do this, then Xirtic als

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 02 July 2013 13:44 > To: Paul Durrant > Cc: Tim (Xen.org); qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > On Tue, 2013-07-02 at 13:35 +0100, Paul Durrant wrote: > > > -Original

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 13:35 +0100, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell > > Sent: 02 July 2013 11:57 > > To: Tim (Xen.org) > > Cc: Paul Durrant; qemu-devel@nongnu.org; xen-de...@lists.xen.org > > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > > > On

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
> -Original Message- > From: Tim Deegan [mailto:t...@xen.org] > Sent: 02 July 2013 11:50 > To: Paul Durrant > Cc: Ian Campbell; qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > At 10:31 + on 02 Jul (1372761105), Paul Durrant wro

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 02 July 2013 11:57 > To: Tim (Xen.org) > Cc: Paul Durrant; qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > On Tue, 2013-07-02 at 11:49 +0100, Tim Deegan wrote: > > At 10:31 + on

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 11:49 +0100, Tim Deegan wrote: > At 10:31 + on 02 Jul (1372761105), Paul Durrant wrote: > > > > Well, the WU drivers could refuse to install except as upgrade to > > > > themselves (i.e. fail if there's any unknown driver bound to the xen > > > > platform device, and also

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Pasi Kärkkäinen
On Tue, Jul 02, 2013 at 11:48:46AM +0100, Ian Campbell wrote: > On Tue, 2013-07-02 at 11:31 +0100, Paul Durrant wrote: > > > > XS, XC and anyone else who chooses could carry a separate patch that > > > > changes the default to 'install if there are no drivers', signalling > > > > over xenstore, or

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Tim Deegan
At 10:31 + on 02 Jul (1372761105), Paul Durrant wrote: > > > Well, the WU drivers could refuse to install except as upgrade to > > > themselves (i.e. fail if there's any unknown driver bound to the xen > > > platform device, and also fail if there's _no_ driver bound). Then the > > > guest adm

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 11:31 +0100, Paul Durrant wrote: > > > XS, XC and anyone else who chooses could carry a separate patch that > > > changes the default to 'install if there are no drivers', signalling > > > over xenstore, or ACPI, or a Windows domain policy, or whatever. > > > > Right. > > >

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 02 July 2013 11:24 > To: Tim (Xen.org) > Cc: Paul Durrant; qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > On Tue, 2013-07-02 at 11:15 +0100, Tim Deegan wrote: > > At 10:56 +0100 on

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 02 July 2013 11:24 > To: Tim (Xen.org) > Cc: Paul Durrant; qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > On Tue, 2013-07-02 at 11:15 +0100, Tim Deegan wrote: > > At 10:56 +0100 on

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 11:15 +0100, Tim Deegan wrote: > At 10:56 +0100 on 02 Jul (1372762607), Ian Campbell wrote: > > On Tue, 2013-07-02 at 10:14 +0100, Paul Durrant wrote: > > > I had actually coded up a solution based on the existing Xen platform > > > device, by having it synthesize a device ID

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Tim Deegan
At 10:56 +0100 on 02 Jul (1372762607), Ian Campbell wrote: > On Tue, 2013-07-02 at 10:14 +0100, Paul Durrant wrote: > > I had actually coded up a solution based on the existing Xen platform > > device, by having it synthesize a device ID based on the Xen version > > to which we could then host the

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 10:14 +0100, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell > > Sent: 02 July 2013 09:57 > > To: Paul Durrant > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org > > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > > > On Tue, 2013-07-02

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 02 July 2013 09:57 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > On Tue, 2013-07-02 at 09:39 +0100, Paul Durrant wrote: > > This patch introduces a new PC

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 02 July 2013 10:02 > To: Paul Durrant > Cc: Jan Beulich; qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > On Tue, 2013-07-02 at 08:57 +, Paul Durrant wrote: > > > -Original M

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 08:57 +, Paul Durrant wrote: > > -Original Message- > > From: Jan Beulich [mailto:jbeul...@suse.com] > > Sent: 02 July 2013 09:46 > > To: Paul Durrant > > Cc: xen-de...@lists.xen.org; qemu-devel@nongnu.org > > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device >

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 02 July 2013 09:46 > To: Paul Durrant > Cc: xen-de...@lists.xen.org; qemu-devel@nongnu.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device > > >>> On 02.07.13 at 10:39, Paul Durrant wrote: > > --- a/includ

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 09:39 +0100, Paul Durrant wrote: > This patch introduces a new PCI device which will act as the binding point > for Citrix branded PV drivers for Xen. > The intention is that Citrix Windows PV drivers will be available on Windows > Update and thus using the existing Xen platfo

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Jan Beulich
>>> On 02.07.13 at 10:39, Paul Durrant wrote: > --- a/include/hw/pci/pci_ids.h > +++ b/include/hw/pci/pci_ids.h > @@ -151,4 +151,7 @@ > #define PCI_VENDOR_ID_TEWS 0x1498 > #define PCI_DEVICE_ID_TEWS_TPCI200 0x30C8 > > +#define PCI_VENDOR_ID_CITRIX 0x5853 Is tha