Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Gerd Hoffmann
On 07/20/12 14:47, Kevin O'Connor wrote: > On Fri, Jul 20, 2012 at 09:33:05AM +0200, Gerd Hoffmann wrote: >> My concern isn't DMA'ing to the stack, but the size of the script and >> possible stack overruns. But maybe it is a moot point with the stack >> switching added to seabios recently. > > Di

Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Kevin O'Connor
On Fri, Jul 20, 2012 at 09:33:05AM +0200, Gerd Hoffmann wrote: > Hi, > > >> +/* FIXME: probably not the best idea to have this on the stack ... */ > >> +u32 script[] = { > > > > Several places in the code DMA to the stack already (usb-ehci, > > usb-uhci, ata). > > My concern isn't DMA'

Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Gerd Hoffmann
Hi, >> +/* FIXME: probably not the best idea to have this on the stack ... */ >> +u32 script[] = { > > Several places in the code DMA to the stack already (usb-ehci, > usb-uhci, ata). My concern isn't DMA'ing to the stack, but the size of the script and possible stack overruns. But ma

Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-19 Thread Kevin O'Connor
On Thu, Jul 19, 2012 at 06:15:03PM +0200, Gerd Hoffmann wrote: > This patch adds support for the lsi53c895a scsi host adapter, > allowing seabios to boot from scsi disks and cdroms connected > to the lsi scsi hba emulated by qemu. > > This driver was written by looking at the expectations of qemu'