Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code

2015-03-02 Thread Gerd Hoffmann
Hi, > Gerd, btw I think we mighr want to support a set scanout with no > resource, as it might make Linux atomic modesetting easier in the > future, we'd just scanout black. Makes sense, and should be easy to implement. > > However, I think it's best to simply limit ab->nr_entries to some sane

Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code

2015-03-01 Thread Dave Airlie
> > But one non-formal question: As far as I understood virtio-gpu's mode of > operation from this patch, it looks like there is one resource per scanout, > and that resource is basically the whole screen (which can be updated > partially). > > If that is the case, what do we gain from being able t

Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code

2015-02-27 Thread Max Reitz
On 2015-02-27 at 09:31, Gerd Hoffmann wrote: +if (t2d.offset || t2d.r.x || t2d.r.y || +t2d.r.width != pixman_image_get_width(res->image)) { Will this work with stride != t2d.r.width * bpp? Those cases should take the if branch above and loop over all lines to handle it correctly. E

Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code

2015-02-27 Thread Gerd Hoffmann
> >>> +if (t2d.offset || t2d.r.x || t2d.r.y || > >>> +t2d.r.width != pixman_image_get_width(res->image)) { > >> Will this work with stride != t2d.r.width * bpp? > > Those cases should take the if branch above and loop over all lines to > > handle it correctly. > > Exactly, but it look

Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code

2015-02-27 Thread Max Reitz
On 2015-02-27 at 06:10, Gerd Hoffmann wrote: On Do, 2015-02-26 at 11:08 -0500, Max Reitz wrote: On 2015-02-23 at 05:23, Gerd Hoffmann wrote: This patch adds the core code for virtio gpu emulation, covering 2d support. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie Signed

Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code

2015-02-27 Thread Gerd Hoffmann
On Do, 2015-02-26 at 11:08 -0500, Max Reitz wrote: > On 2015-02-23 at 05:23, Gerd Hoffmann wrote: > > This patch adds the core code for virtio gpu emulation, > > covering 2d support. > > > > Written by Dave Airlie and Gerd Hoffmann. > > > > Signed-off-by: Dave Airlie > > Signed-off-by: Gerd Hoffman

Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code

2015-02-26 Thread Max Reitz
On 2015-02-23 at 05:23, Gerd Hoffmann wrote: This patch adds the core code for virtio gpu emulation, covering 2d support. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- hw/display/Makefile.objs | 2 + hw/display/virtio-gpu.c

[Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code

2015-02-23 Thread Gerd Hoffmann
This patch adds the core code for virtio gpu emulation, covering 2d support. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- hw/display/Makefile.objs | 2 + hw/display/virtio-gpu.c| 903 ++