Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.

2012-03-09 Thread Gerd Hoffmann
Hi, >> 'dev-' isn't the greated pick as it is somewhat generic indeed. I've >> also considered 'emu-' (to contrast with host-*), but it has pretty much >> the same issue. Other suggestions? > > Looks like all your dev- actually start with dev-usb-. No, they don't, I've dropped 'usb-' prefix

Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 07:50, Gerd Hoffmann ha scritto: > I want a prefix because with prefixing you get the files nicely grouped > in directory listings, without creating another directory level, which > would IMHO be overkill for the number of files we have here. > > 'dev-*' is used for emulated usb devi

Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.

2012-03-09 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> For another, dev-foo.c is not natural English for a certain type of >> device - foo-dev.c would be better but I'd prefer without "dev", i.e., >> hw/usb/{audio,ccid,...}.c. And then of course only devices should go >> into hw/. > > I want a prefix because with pr

Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.

2012-03-08 Thread Gerd Hoffmann
Hi, > For another, dev-foo.c is not natural English for a certain type of > device - foo-dev.c would be better but I'd prefer without "dev", i.e., > hw/usb/{audio,ccid,...}.c. And then of course only devices should go > into hw/. I want a prefix because with prefixing you get the files nicely g

Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.

2012-03-08 Thread Anthony Liguori
On 03/08/2012 03:16 AM, Gerd Hoffmann wrote: Hi, Plan is basically to move all usb stuff to hw/usb/ Comments? It's easy to bikeshed something like this but since it's clearly an improvement over what we have right now, I'm all for it. Regards, Anthony Liguori cheers, Gerd Gerd H

Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.

2012-03-08 Thread Andreas Färber
Am 08.03.2012 10:16, schrieb Gerd Hoffmann: > Plan is basically to move all usb stuff to hw/usb/ > > Comments? hw/usb/ is fine with me (hw/ide/ is precedence), but I strongly dislike the dev-*.c convention you've used: For one thing, we'd have to rename 90+% of hw/ to be consistent. For another

[Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.

2012-03-08 Thread Gerd Hoffmann
Hi, Plan is basically to move all usb stuff to hw/usb/ Comments? cheers, Gerd Gerd Hoffmann (2): usb: the big rename usb: zap hw/ush-{ohic,uhci}.h + init wrappers Makefile.objs | 22 -- Makefile.target|2 +- co