Re: [Qemu-devel] [RISU PATCH v4 05/10] risu: paramterise send/receive functions

2017-06-06 Thread Peter Maydell
On 6 June 2017 at 11:13, Alex Bennée wrote: > Peter Maydell writes: >> If you're going to fix the indent can you put that in >> its own patch, please? Much easier to review that way. > > Damn I forgotten that got munged. Can we agree on what the indent should > be for risu? 3 or 4, space or tabs?

Re: [Qemu-devel] [RISU PATCH v4 05/10] risu: paramterise send/receive functions

2017-06-06 Thread Alex Bennée
Peter Maydell writes: > On 2 June 2017 at 17:08, Alex Bennée wrote: >> This is a precursor to record/playback support. Instead of passing the >> socket fd we now pass helper functions for reading/writing and >> responding. This will allow us to do the rest of the record/playback >> cleanly outs

Re: [Qemu-devel] [RISU PATCH v4 05/10] risu: paramterise send/receive functions

2017-06-06 Thread Peter Maydell
On 2 June 2017 at 17:08, Alex Bennée wrote: > This is a precursor to record/playback support. Instead of passing the > socket fd we now pass helper functions for reading/writing and > responding. This will allow us to do the rest of the record/playback > cleanly outside of the main worker function

[Qemu-devel] [RISU PATCH v4 05/10] risu: paramterise send/receive functions

2017-06-02 Thread Alex Bennée
This is a precursor to record/playback support. Instead of passing the socket fd we now pass helper functions for reading/writing and responding. This will allow us to do the rest of the record/playback cleanly outside of the main worker function. Signed-off-by: Alex Bennée --- v4 - split head