Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2018-01-11 Thread Peter Xu
On Tue, Jan 09, 2018 at 01:42:08PM +, Stefan Hajnoczi wrote: > On Tue, Dec 19, 2017 at 04:45:48PM +0800, Peter Xu wrote: > > @@ -4071,6 +4073,9 @@ static void handle_qmp_command(JSONMessageParser > > *parser, GQueue *tokens) > > req_obj->req = req; > > req_obj->need_resume = false; >

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2018-01-09 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:48PM +0800, Peter Xu wrote: > @@ -4071,6 +4073,9 @@ static void handle_qmp_command(JSONMessageParser > *parser, GQueue *tokens) > req_obj->req = req; > req_obj->need_resume = false; > > +/* Protect qmp_requests and fetching its length. */ > +qemu_m

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2018-01-09 Thread Stefan Hajnoczi
On Mon, Dec 25, 2017 at 03:22:24PM +0800, Peter Xu wrote: > On Mon, Dec 25, 2017 at 03:13:49PM +0800, Fam Zheng wrote: > > On Mon, 12/25 14:18, Peter Xu wrote: > > > On Mon, Dec 25, 2017 at 01:55:56PM +0800, Fam Zheng wrote: > > > > On Mon, 12/25 13:18, Peter Xu wrote: > > > > > On Thu, Dec 21, 201

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-24 Thread Peter Xu
On Mon, Dec 25, 2017 at 03:13:49PM +0800, Fam Zheng wrote: > On Mon, 12/25 14:18, Peter Xu wrote: > > On Mon, Dec 25, 2017 at 01:55:56PM +0800, Fam Zheng wrote: > > > On Mon, 12/25 13:18, Peter Xu wrote: > > > > On Thu, Dec 21, 2017 at 07:42:46PM +0800, Fam Zheng wrote: > > > > > On Tue, 12/19 16:4

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-24 Thread Fam Zheng
On Mon, 12/25 14:18, Peter Xu wrote: > On Mon, Dec 25, 2017 at 01:55:56PM +0800, Fam Zheng wrote: > > On Mon, 12/25 13:18, Peter Xu wrote: > > > On Thu, Dec 21, 2017 at 07:42:46PM +0800, Fam Zheng wrote: > > > > On Tue, 12/19 16:45, Peter Xu wrote: > > > > > Set maximum QMP command queue length to

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-24 Thread Peter Xu
On Mon, Dec 25, 2017 at 01:55:56PM +0800, Fam Zheng wrote: > On Mon, 12/25 13:18, Peter Xu wrote: > > On Thu, Dec 21, 2017 at 07:42:46PM +0800, Fam Zheng wrote: > > > On Tue, 12/19 16:45, Peter Xu wrote: > > > > Set maximum QMP command queue length to 8. If queue full, instead of > > > > queue the

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-24 Thread Fam Zheng
On Mon, 12/25 13:18, Peter Xu wrote: > On Thu, Dec 21, 2017 at 07:42:46PM +0800, Fam Zheng wrote: > > On Tue, 12/19 16:45, Peter Xu wrote: > > > Set maximum QMP command queue length to 8. If queue full, instead of > > > queue the command, we directly return a "command-dropped" event, telling > > >

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-24 Thread Peter Xu
On Thu, Dec 21, 2017 at 07:42:46PM +0800, Fam Zheng wrote: > On Tue, 12/19 16:45, Peter Xu wrote: > > Set maximum QMP command queue length to 8. If queue full, instead of > > queue the command, we directly return a "command-dropped" event, telling > > client that specific command is dropped. > >

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-21 Thread Fam Zheng
On Tue, 12/19 16:45, Peter Xu wrote: > Set maximum QMP command queue length to 8. If queue full, instead of > queue the command, we directly return a "command-dropped" event, telling > client that specific command is dropped. > > Note that this flow control mechanism is only valid if OOB is enabl

[Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-19 Thread Peter Xu
Set maximum QMP command queue length to 8. If queue full, instead of queue the command, we directly return a "command-dropped" event, telling client that specific command is dropped. Note that this flow control mechanism is only valid if OOB is enabled. If it's not, the effective queue length wil