Re: [Qemu-devel] [RFC v6 16/27] monitor: separate QMP parser and dispatcher

2018-01-12 Thread Stefan Hajnoczi
On Fri, Jan 12, 2018 at 02:05:15PM +0800, Peter Xu wrote: > On Mon, Jan 08, 2018 at 05:09:16PM +, Stefan Hajnoczi wrote: > > On Tue, Dec 19, 2017 at 04:45:46PM +0800, Peter Xu wrote: > > > > > + */ > > > +bool need_resume; > > > > This isn't really a per-request decision so a QMPReque

Re: [Qemu-devel] [RFC v6 16/27] monitor: separate QMP parser and dispatcher

2018-01-11 Thread Peter Xu
On Mon, Jan 08, 2018 at 05:09:16PM +, Stefan Hajnoczi wrote: > On Tue, Dec 19, 2017 at 04:45:46PM +0800, Peter Xu wrote: > > Originally QMP goes throw these steps: > > s/throw/through/ > > > > > JSON Parser --> QMP Dispatcher --> Respond > > /|\(2)(3) | > >

Re: [Qemu-devel] [RFC v6 16/27] monitor: separate QMP parser and dispatcher

2018-01-08 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:46PM +0800, Peter Xu wrote: > Originally QMP goes throw these steps: s/throw/through/ > > JSON Parser --> QMP Dispatcher --> Respond > /|\(2)(3) | >(1) | \|/ (4) >+- main thread

Re: [Qemu-devel] [RFC v6 16/27] monitor: separate QMP parser and dispatcher

2017-12-24 Thread Peter Xu
On Thu, Dec 21, 2017 at 07:40:13PM +0800, Fam Zheng wrote: [...] > > +/* > > + * Pop one QMP request from monitor queues, return NULL if not found. > > + * We are using round-robin fasion to pop the request, to avoid > > s/fasion/fashion/ Fixed. [...] > > static void monitor_qmp_read(void *o

Re: [Qemu-devel] [RFC v6 16/27] monitor: separate QMP parser and dispatcher

2017-12-21 Thread Fam Zheng
On Tue, 12/19 16:45, Peter Xu wrote: > Originally QMP goes throw these steps: > > JSON Parser --> QMP Dispatcher --> Respond > /|\(2)(3) | >(1) | \|/ (4) >+- main thread + > > This patch does this: > >

[Qemu-devel] [RFC v6 16/27] monitor: separate QMP parser and dispatcher

2017-12-19 Thread Peter Xu
Originally QMP goes throw these steps: JSON Parser --> QMP Dispatcher --> Respond /|\(2)(3) | (1) | \|/ (4) +- main thread + This patch does this: JSON Parser QMP Dispatcher --> Respond /|\ |