Re: [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

2018-08-23 Thread Marc-André Lureau
Hi On Fri, Jan 5, 2018 at 6:22 PM Stefan Hajnoczi wrote: > > On Tue, Dec 19, 2017 at 04:45:40PM +0800, Peter Xu wrote: > > if (monitor_is_qmp(mon)) { > > -qemu_chr_fe_set_handlers(&mon->chr, monitor_can_read, > > monitor_qmp_read, > > - monitor_qmp_ev

Re: [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

2018-01-11 Thread Peter Xu
On Fri, Jan 05, 2018 at 05:22:26PM +, Stefan Hajnoczi wrote: > On Tue, Dec 19, 2017 at 04:45:40PM +0800, Peter Xu wrote: > > if (monitor_is_qmp(mon)) { > > -qemu_chr_fe_set_handlers(&mon->chr, monitor_can_read, > > monitor_qmp_read, > > - monitor_qm

Re: [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

2018-01-11 Thread Peter Xu
On Tue, Jan 09, 2018 at 05:37:39PM -0600, Eric Blake wrote: > On 12/19/2017 02:45 AM, Peter Xu wrote: > > Grammar in the subject: > > "allow to $VERB" is not idiomatic English; correct is either "allow > ${VERB}ing" or "allow $SUBJECT to $VERB". Concretely, s/to use/using/ > > > For each Monito

Re: [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

2018-01-09 Thread Eric Blake
On 12/19/2017 02:45 AM, Peter Xu wrote: Grammar in the subject: "allow to $VERB" is not idiomatic English; correct is either "allow ${VERB}ing" or "allow $SUBJECT to $VERB". Concretely, s/to use/using/ > For each Monitor, add one field "use_io_thr" to show whether it will be > using the dedicat

Re: [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

2018-01-05 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:40PM +0800, Peter Xu wrote: > if (monitor_is_qmp(mon)) { > -qemu_chr_fe_set_handlers(&mon->chr, monitor_can_read, > monitor_qmp_read, > - monitor_qmp_event, NULL, mon, NULL, true); > qemu_chr_fe_set_echo(&mon->chr,

Re: [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

2017-12-21 Thread Fam Zheng
On Tue, 12/19 16:45, Peter Xu wrote: > For each Monitor, add one field "use_io_thr" to show whether it will be > using the dedicated monitor IO thread to handle input/output. When set, > monitor IO parsing work will be offloaded to dedicated monitor IO > thread, rather than the original main loop

[Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

2017-12-19 Thread Peter Xu
For each Monitor, add one field "use_io_thr" to show whether it will be using the dedicated monitor IO thread to handle input/output. When set, monitor IO parsing work will be offloaded to dedicated monitor IO thread, rather than the original main loop thread. This only works for QMP. HMP will a