Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-18 Thread Claudio Fontana
Hello Eric, On 15 May 2015 at 18:01, Eric Blake wrote: > On 05/15/2015 09:13 AM, Claudio Fontana wrote: > >>> Or back to the original question - why are we worrying about the O(n) >>> memmem implementation when the naive O(n^2) is MUCH shorter and easier >>> to understand, and where the scaling p

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-15 Thread Eric Blake
On 05/15/2015 09:13 AM, Claudio Fontana wrote: >> Or back to the original question - why are we worrying about the O(n) >> memmem implementation when the naive O(n^2) is MUCH shorter and easier >> to understand, and where the scaling penalty is only apparent on really >> long corner case strings?

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-15 Thread Claudio Fontana
Hello Eric, On 15.05.2015 16:56, Eric Blake wrote: > On 05/15/2015 08:12 AM, Paolo Bonzini wrote: >> >> >> On 15/05/2015 15:57, Claudio Fontana wrote: >>> The header here mentions GPLv2+, but the module data for memmem in gnulib >>> mentions LGPLv2+. >>> >>> Very confusing. >>> >>> The COPYING fi

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-15 Thread Eric Blake
On 05/15/2015 08:12 AM, Paolo Bonzini wrote: > > > On 15/05/2015 15:57, Claudio Fontana wrote: >> The header here mentions GPLv2+, but the module data for memmem in gnulib >> mentions LGPLv2+. >> >> Very confusing. >> >> The COPYING file in gnulib mentions: >> >> "The files in here are mostly co

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-15 Thread Paolo Bonzini
On 15/05/2015 15:57, Claudio Fontana wrote: > The header here mentions GPLv2+, but the module data for memmem in gnulib > mentions LGPLv2+. > > Very confusing. > > The COPYING file in gnulib mentions: > > "The files in here are mostly copyright (C) Free Software Foundation, and > are under as

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-15 Thread Claudio Fontana
Hmm some licensing weirdness: On 15.05.2015 14:25, hw.clau...@gmail.com wrote: > From: Claudio Fontana > > if the memmem function is missing, provide the gnulib replacement. > > Signed-off-by: Claudio Fontana > --- > configure| 15 ++ > include/qemu/osdep.h | 4 + > util/Makefi