Re: [Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-30 Thread Alex Bennée
Paolo Bonzini writes: > On 29/10/2018 22:39, Emilio G. Cota wrote: >> I'm not convinced about adding an "assert(!user-mode)" to run_on_cpu. >> Given that now it does not depend on the BQL, it could actually >> work in user-mode if called. If we really wanted to make sure >> that no user-mode wo

Re: [Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-30 Thread Paolo Bonzini
On 29/10/2018 22:39, Emilio G. Cota wrote: > I'm not convinced about adding an "assert(!user-mode)" to run_on_cpu. > Given that now it does not depend on the BQL, it could actually > work in user-mode if called. If we really wanted to make sure > that no user-mode would call it, then a compile-time

Re: [Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-29 Thread Emilio G. Cota
On Mon, Oct 29, 2018 at 16:34:49 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > We don't pass a pointer to qemu_global_mutex anymore. > > > > Reviewed-by: Richard Henderson > > Signed-off-by: Emilio G. Cota > > As discussed on IRC I don't fundamentally object to this being in > cp

Re: [Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-29 Thread Alex Bennée
Emilio G. Cota writes: > We don't pass a pointer to qemu_global_mutex anymore. > > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota As discussed on IRC I don't fundamentally object to this being in cpus-common given we have the other work queue stuff there. However given it now

[Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-25 Thread Emilio G. Cota
We don't pass a pointer to qemu_global_mutex anymore. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 10 -- cpus-common.c | 2 +- cpus.c| 5 - 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/include/qom/cpu.h b/i