Re: [Qemu-devel] [RFC v3 25/56] exec: use cpu_reset_interrupt

2018-10-22 Thread Emilio G. Cota
On Sun, Oct 21, 2018 at 14:17:01 +0100, Richard Henderson wrote: > On 10/19/18 2:05 AM, Emilio G. Cota wrote: > > -cpu->interrupt_request &= ~0x01; > > +cpu_reset_interrupt(cpu, ~0x01); > > cpu_reset_interrupt(cpu, 1); Ouch. Fixed. > Although this is during vmload, and I'm not sure what

Re: [Qemu-devel] [RFC v3 25/56] exec: use cpu_reset_interrupt

2018-10-21 Thread Richard Henderson
On 10/19/18 2:05 AM, Emilio G. Cota wrote: > -cpu->interrupt_request &= ~0x01; > +cpu_reset_interrupt(cpu, ~0x01); cpu_reset_interrupt(cpu, 1); Although this is during vmload, and I'm not sure what locks you really want to play with here. Perhaps it's ok... r~

[Qemu-devel] [RFC v3 25/56] exec: use cpu_reset_interrupt

2018-10-18 Thread Emilio G. Cota
Cc: Peter Crosthwaite Cc: Richard Henderson Signed-off-by: Emilio G. Cota --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 4fd831ef06..6006902975 100644 --- a/exec.c +++ b/exec.c @@ -776,7 +776,7 @@ static int cpu_common_post_load(void *opaque