Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-25 Thread Pankaj Gupta
> > >> > >> This patch has no n/M in the subject line; but is included in a thread > >> that also has a 0/2 cover letter, as well as 1/2 and 2/2 patches in > >> separate mails. Is that intentional? > > > > Yes, kernel series has 0-2 patches and Qemu has this one. I thought its > > good to ke

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-25 Thread Eric Blake
On 07/25/2018 12:01 AM, Pankaj Gupta wrote: This patch has no n/M in the subject line; but is included in a thread that also has a 0/2 cover letter, as well as 1/2 and 2/2 patches in separate mails. Is that intentional? Yes, kernel series has 0-2 patches and Qemu has this one. I thought its

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-24 Thread Pankaj Gupta
Hi Eric, > > On 07/13/2018 02:52 AM, Pankaj Gupta wrote: > > This patch adds virtio-pmem Qemu device. > > > > This device presents memory address range information to guest > > which is backed by file backend type. It acts like persistent > > memory device for KVM guest. Guest can perf

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-24 Thread Eric Blake
On 07/13/2018 02:52 AM, Pankaj Gupta wrote: This patch adds virtio-pmem Qemu device. This device presents memory address range information to guest which is backed by file backend type. It acts like persistent memory device for KVM guest. Guest can perform read and persistent write ope

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-20 Thread Pankaj Gupta
> > > > > + > > > > > +typedef struct VirtIOPMEMresp { > > > > > +int ret; > > > > > +} VirtIOPMEMResp; > > > > > + > > > > > +typedef struct VirtIODeviceRequest { > > > > > +VirtQueueElement elem; > > > > > +int fd; > > > > > +VirtIOPMEM *pmem; > > > > > +VirtIOPMEMResp resp;

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-20 Thread Pankaj Gupta
> /* > * virtio-balloon-pci: This extends VirtioPCIProxy. > */ > diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c > new file mode 100644 > index 00..08c96d7e80 > --- /dev/null > +++ b/hw/virtio/virtio-pmem.c > @@ -0,0 +1,241

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-19 Thread Luiz Capitulino
On Thu, 19 Jul 2018 15:58:20 +0200 David Hildenbrand wrote: > On 19.07.2018 14:16, Stefan Hajnoczi wrote: > > On Thu, Jul 19, 2018 at 01:48:13AM -0400, Pankaj Gupta wrote: > >> > >>> > This patch adds virtio-pmem Qemu device. > > This device presents memory address range in

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-19 Thread David Hildenbrand
On 19.07.2018 14:16, Stefan Hajnoczi wrote: > On Thu, Jul 19, 2018 at 01:48:13AM -0400, Pankaj Gupta wrote: >> >>> This patch adds virtio-pmem Qemu device. This device presents memory address range information to guest which is backed by file backend type. It acts like persis

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-19 Thread Luiz Capitulino
On Thu, 19 Jul 2018 08:48:19 -0400 Luiz Capitulino wrote: > > It will be necessary to define specific constants for virtio-pmem > > instead of passing errno from the host to guest. > > Yes, defining your own constants work. But I think the only fsync() > error that will make sense for the gues

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-19 Thread Luiz Capitulino
On Thu, 19 Jul 2018 13:16:35 +0100 Stefan Hajnoczi wrote: > On Thu, Jul 19, 2018 at 01:48:13AM -0400, Pankaj Gupta wrote: > > > > > > > > > This patch adds virtio-pmem Qemu device. > > > > > > > > This device presents memory address range information to guest > > > > which is backed by

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-19 Thread Luiz Capitulino
On Thu, 19 Jul 2018 01:48:13 -0400 (EDT) Pankaj Gupta wrote: > > > > > This patch adds virtio-pmem Qemu device. > > > > > > This device presents memory address range information to guest > > > which is backed by file backend type. It acts like persistent > > > memory device for KVM guest.

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-19 Thread Stefan Hajnoczi
On Thu, Jul 19, 2018 at 01:48:13AM -0400, Pankaj Gupta wrote: > > > > > > This patch adds virtio-pmem Qemu device. > > > > > > This device presents memory address range information to guest > > > which is backed by file backend type. It acts like persistent > > > memory device for KVM guest.

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-18 Thread Pankaj Gupta
> > > This patch adds virtio-pmem Qemu device. > > > > This device presents memory address range information to guest > > which is backed by file backend type. It acts like persistent > > memory device for KVM guest. Guest can perform read and persistent > > write operations on this memory

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-18 Thread Luiz Capitulino
On Fri, 13 Jul 2018 13:22:32 +0530 Pankaj Gupta wrote: > This patch adds virtio-pmem Qemu device. > > This device presents memory address range information to guest > which is backed by file backend type. It acts like persistent > memory device for KVM guest. Guest can perform read and persi

[Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-13 Thread Pankaj Gupta
This patch adds virtio-pmem Qemu device. This device presents memory address range information to guest which is backed by file backend type. It acts like persistent memory device for KVM guest. Guest can perform read and persistent write operations on this memory range with the help of DAX c