Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-23 Thread Claudio Fontana
On 21 April 2015 at 16:47, Paolo Bonzini wrote: > > > On 21/04/2015 16:35, Luiz Capitulino wrote: >> > gladly, I am definitely looking for Review, first I wanted to check if the >> > idea itself was acceptable. >> >> I honestly don't have an opinion on this, which means I'm willing >> to apply if

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Luiz Capitulino
On Tue, 21 Apr 2015 16:25:12 +0200 Claudio Fontana wrote: > Hello Luiz, > > On 21.04.2015 00:01, Luiz Capitulino wrote: > > On Fri, 27 Mar 2015 17:19:30 +0100 > > Claudio Fontana wrote: > > > >> Just a respectful ping on this one.. > >> Luiz do you think you can integrate this into the monitor

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Claudio Fontana
On 21.04.2015 16:28, Paolo Bonzini wrote: > > > On 21/04/2015 16:25, Claudio Fontana wrote: >> I seem not to get this warning with the compiler version I am currently >> using, >> and after checking the code I could not find out why with some compilers >> would emit such a warning. >> >> It is

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 16:35, Luiz Capitulino wrote: > > gladly, I am definitely looking for Review, first I wanted to check if the > > idea itself was acceptable. > > I honestly don't have an opinion on this, which means I'm willing > to apply if there are no objections. > > On the other hand, isn't i

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 16:25, Claudio Fontana wrote: > I seem not to get this warning with the compiler version I am currently using, > and after checking the code I could not find out why with some compilers > would emit such a warning. > > It is difficult for me to debug this issue since I do not get

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Claudio Fontana
Hello Luiz, On 21.04.2015 00:01, Luiz Capitulino wrote: > On Fri, 27 Mar 2015 17:19:30 +0100 > Claudio Fontana wrote: > >> Just a respectful ping on this one.. >> Luiz do you think you can integrate this into the monitor? > > Would be nice to get a Reviewed-by from someone and, gladly, I am de

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Luiz Capitulino
On Fri, 27 Mar 2015 17:19:30 +0100 Claudio Fontana wrote: > Just a respectful ping on this one.. > Luiz do you think you can integrate this into the monitor? Would be nice to get a Reviewed-by from someone and, I'm getting a build error: /home/lcapitulino/work/src/upstream/qmp-unstable/monitor.

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-30 Thread Paolo Bonzini
On 27/03/2015 17:19, Claudio Fontana wrote: > Just a respectful ping on this one.. > Luiz do you think you can integrate this into the monitor? > > I have given it quite some testing for the LE host case, > I don't have a BE host to test with at the moment, maybe someone can advise > about how

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-27 Thread Claudio Fontana
Just a respectful ping on this one.. Luiz do you think you can integrate this into the monitor? I have given it quite some testing for the LE host case, I don't have a BE host to test with at the moment, maybe someone can advise about how to test that scenario? I was trying to do some qemu under

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-18 Thread Claudio Fontana
Tested with kvm on aarch64 LE host with aarch64 LE guest, tested with tcg on aarch64 LE host with aarch64 LE/sparc BE/x86 LE guests. Would be interesting to test this also on a big endian host with different guest combinations.. Claudio On 16.03.2015 11:31, hw.clau...@gmail.com wrote: > From: Cl

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 16:58, Eric Blake wrote: > On 03/16/2015 09:54 AM, Claudio Fontana wrote: > Do you want to provide a QMP counterpart? In general, we are reluctant to add new HMP functionality that cannot also be accessed via QMP. >>> >>> I think this is okay for a debugging comman

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread Eric Blake
On 03/16/2015 09:54 AM, Claudio Fontana wrote: >>> Do you want to provide a QMP counterpart? In general, we are >>> reluctant to add new HMP functionality that cannot also be accessed >>> via QMP. >> >> I think this is okay for a debugging command. x and xp do not have an >> QMP equivalent eithe

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread Claudio Fontana
On 16.03.2015 16:01, Paolo Bonzini wrote: > > > On 16/03/2015 15:45, Eric Blake wrote: >> On 03/16/2015 04:31 AM, hw.clau...@gmail.com wrote: >>> From: Claudio Fontana >>> >>> usage is similar to the commands x, xp. >>> >>> Example with string: looking for "ELF" header in memory: >>> >>> (qemu)

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 15:45, Eric Blake wrote: > On 03/16/2015 04:31 AM, hw.clau...@gmail.com wrote: >> From: Claudio Fontana >> >> usage is similar to the commands x, xp. >> >> Example with string: looking for "ELF" header in memory: >> >> (qemu) s/100cb 0x40001000 "ELF" searching memory area >>

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread Claudio Fontana
On 16 March 2015 at 15:45, Eric Blake wrote: > On 03/16/2015 04:31 AM, hw.clau...@gmail.com wrote: >> From: Claudio Fontana >> >> usage is similar to the commands x, xp. >> >> Example with string: looking for "ELF" header in memory: >> >> (qemu) s/100cb 0x40001000 "ELF" >> searching memory ar

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread Eric Blake
On 03/16/2015 04:31 AM, hw.clau...@gmail.com wrote: > From: Claudio Fontana > > usage is similar to the commands x, xp. > > Example with string: looking for "ELF" header in memory: > > (qemu) s/100cb 0x40001000 "ELF" > searching memory area [40001000-400f5240] > 4009

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread Patchew Tool
This series failed Patchew automatic testing. Find the log fragments below (grepped lines around keywords "error" and "warning"), or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<1426501911-1402-1-git-send-email-hw.clau...@gmail.com> --8<- C

[Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread hw . claudio
From: Claudio Fontana usage is similar to the commands x, xp. Example with string: looking for "ELF" header in memory: (qemu) s/100cb 0x40001000 "ELF" searching memory area [40001000-400f5240] 40090001 (qemu) x/20b 0x4009 4009: '\x7f' 'E' 'L' 'F' '\x0