Re: [Qemu-devel] [RFC v2 3/9] virtio: stop virtqueue processing if device is broken

2016-03-30 Thread Stefan Hajnoczi
On Tue, Mar 29, 2016 at 06:58:03PM +0200, Cornelia Huck wrote: > On Tue, 29 Mar 2016 17:12:55 +0100 > Stefan Hajnoczi wrote: > > > QEMU prints an error message and exits when the device enters an invalid > > state. Terminating the process is heavy-handed. The guest may still be > > able to func

Re: [Qemu-devel] [RFC v2 3/9] virtio: stop virtqueue processing if device is broken

2016-03-30 Thread Stefan Hajnoczi
On Tue, Mar 29, 2016 at 06:58:03PM +0200, Cornelia Huck wrote: > On Tue, 29 Mar 2016 17:12:55 +0100 > Stefan Hajnoczi wrote: > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > > index 2b5b248..1565e53 100644 > > --- a/include/hw/virtio/virtio.h > > +++ b/include/hw/virtio/v

Re: [Qemu-devel] [RFC v2 3/9] virtio: stop virtqueue processing if device is broken

2016-03-29 Thread Cornelia Huck
On Tue, 29 Mar 2016 17:12:55 +0100 Stefan Hajnoczi wrote: > QEMU prints an error message and exits when the device enters an invalid > state. Terminating the process is heavy-handed. The guest may still be > able to function even if there is a bug in a virtio guest driver. > > Moreover, exitin

[Qemu-devel] [RFC v2 3/9] virtio: stop virtqueue processing if device is broken

2016-03-29 Thread Stefan Hajnoczi
QEMU prints an error message and exits when the device enters an invalid state. Terminating the process is heavy-handed. The guest may still be able to function even if there is a bug in a virtio guest driver. Moreover, exiting is a bug in nested virtualization where a nested guest could DoS oth