Re: [Qemu-devel] [RFC v2 3/8] char-io: fix possible risk on IOWatchPoll

2017-08-27 Thread Peter Xu
On Sat, Aug 26, 2017 at 03:19:39PM +0800, Fam Zheng wrote: > s/risk/race/ for $subject and the whole patch? I think... Yes. :-) Thanks. -- Peter Xu

Re: [Qemu-devel] [RFC v2 3/8] char-io: fix possible risk on IOWatchPoll

2017-08-26 Thread Fam Zheng
s/risk/race/ for $subject and the whole patch? Fam On Wed, 08/23 14:51, Peter Xu wrote: > This is not a problem if we are only having one single loop thread like > before. However, after per-monitor thread is introduced, this is not > true any more, and the risk can happen. > > The risk can be

Re: [Qemu-devel] [RFC v2 3/8] char-io: fix possible risk on IOWatchPoll

2017-08-25 Thread Marc-André Lureau
On Wed, Aug 23, 2017 at 8:54 AM Peter Xu wrote: > This is not a problem if we are only having one single loop thread like > before. However, after per-monitor thread is introduced, this is not > true any more, and the risk can happen. > > The risk can be triggered with "make check -j8" sometimes

[Qemu-devel] [RFC v2 3/8] char-io: fix possible risk on IOWatchPoll

2017-08-22 Thread Peter Xu
This is not a problem if we are only having one single loop thread like before. However, after per-monitor thread is introduced, this is not true any more, and the risk can happen. The risk can be triggered with "make check -j8" sometimes: qemu-system-x86_64: /root/git/qemu/chardev/char-io.c:9