Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture

2012-10-18 Thread Peter Maydell
On 18 October 2012 18:41, Jan Kiszka wrote: > Minor: If you do > > function() > { > #ifdef CONFIG_KVM > ... > #endif > } > >> + >> qemu_irq *arm_pic_init_cpu(ARMCPU *cpu) >> { >> +#ifdef CONFIG_KVM >> +if (kvm_enabled()) { >> +return qemu_allocate_irqs(kvm_arm_pic_cpu_handler, cpu, 2

Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture

2012-10-18 Thread Jan Kiszka
On 2012-10-10 17:07, Peter Maydell wrote: > From: Christoffer Dall > > Add basic support for KVM on ARM architecture. > > Signed-off-by: Christoffer Dall > [PMM: Minor tweaks and code cleanup, switch to ONE_REG] > Signed-off-by: Peter Maydell > --- > hw/arm_pic.c | 28 > ta

Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture

2012-10-18 Thread Peter Maydell
On 13 October 2012 10:09, Blue Swirl wrote: > On Wed, Oct 10, 2012 at 3:07 PM, Peter Maydell > wrote: >> +#include "hw/arm-misc.h" >> + >> +const KVMCapabilityInfo kvm_arch_required_capabilities[] = { > > 'static'. In fact, 'static' not used at all in this file, probably it > could be used a lot

Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture

2012-10-13 Thread Peter Maydell
On 13 October 2012 10:09, Blue Swirl wrote: > On Wed, Oct 10, 2012 at 3:07 PM, Peter Maydell > wrote: >> From: Christoffer Dall >> >> Add basic support for KVM on ARM architecture. >> +#include "device_tree.h" > > Is this used? Don't think so, will remove. >> +#include "hw/arm-misc.h" >> + >>

Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture

2012-10-13 Thread Blue Swirl
On Wed, Oct 10, 2012 at 3:07 PM, Peter Maydell wrote: > From: Christoffer Dall > > Add basic support for KVM on ARM architecture. > > Signed-off-by: Christoffer Dall > [PMM: Minor tweaks and code cleanup, switch to ONE_REG] > Signed-off-by: Peter Maydell > --- > hw/arm_pic.c | 28

[Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture

2012-10-10 Thread Peter Maydell
From: Christoffer Dall Add basic support for KVM on ARM architecture. Signed-off-by: Christoffer Dall [PMM: Minor tweaks and code cleanup, switch to ONE_REG] Signed-off-by: Peter Maydell --- hw/arm_pic.c | 28 target-arm/Makefile.objs |1 + target-arm/cpu.h |