Re: [Qemu-devel] [RFC v2 1/5] vmstate: reduce code duplication

2014-03-24 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > move size offset and number of elements math out > to functions, to reduce code duplication. Reviewed-by: Dr. David Alan Gilbert If this was new code I would have rejected the use of signed 'int' for something counting the number of elements and si

[Qemu-devel] [RFC v2 1/5] vmstate: reduce code duplication

2014-03-24 Thread Michael S. Tsirkin
move size offset and number of elements math out to functions, to reduce code duplication. Signed-off-by: Michael S. Tsirkin --- vmstate.c | 97 ++- 1 file changed, 52 insertions(+), 45 deletions(-) diff --git a/vmstate.c b/vmstate.c i