Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API

2018-12-14 Thread Emilio G. Cota
On Fri, Dec 14, 2018 at 18:47:42 +, Aaron Lindsay wrote: > On Dec 14 12:50, Emilio G. Cota wrote: > > On Fri, Dec 14, 2018 at 12:08:22 -0500, Emilio G. Cota wrote: > > > On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote: > > (snip) > > > > I added a function to the user-facing plugin

Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API

2018-12-14 Thread Aaron Lindsay
On Dec 14 12:50, Emilio G. Cota wrote: > On Fri, Dec 14, 2018 at 12:08:22 -0500, Emilio G. Cota wrote: > > On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote: > (snip) > > > I added a function to the user-facing plugin API in my own version of > > > Pavel's plugin patchset to clear all exi

Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API

2018-12-14 Thread Emilio G. Cota
On Fri, Dec 14, 2018 at 17:59:20 +, Aaron Lindsay wrote: > On Dec 14 12:08, Emilio G. Cota wrote: (snip) > > The idea is that a plugin can "reset" itself, so that (1) all > > its CBs are cleared and (2) the plugin can register new callbacks. > > This would all happen in an atomic context (no vC

Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API

2018-12-14 Thread Aaron Lindsay
On Dec 14 12:08, Emilio G. Cota wrote: > On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote: > > Emilio, > > > > First, thanks for putting this together - I think everyone doing this > > sort of thing will benefit if we're able to agree on one upstream plugin > > interface. > > > > One t

Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API

2018-12-14 Thread Emilio G. Cota
On Fri, Dec 14, 2018 at 12:08:22 -0500, Emilio G. Cota wrote: > On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote: (snip) > > I added a function to the user-facing plugin API in my own version of > > Pavel's plugin patchset to clear all existing plugin instrumentation, (snip) > I think th

Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API

2018-12-14 Thread Emilio G. Cota
On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote: > Emilio, > > First, thanks for putting this together - I think everyone doing this > sort of thing will benefit if we're able to agree on one upstream plugin > interface. > > One thing I'd like to see is support for unregistering callb

Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API

2018-12-14 Thread Aaron Lindsay
On Dec 14 10:57, Aaron Lindsay wrote: > One thing I'd like to see is support for unregistering callbacks once > they are registered. By the way, I'm willing to work on this if we agree it sounds reasonable and fits in with the rest of your implementation. -Aaron

Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API

2018-12-14 Thread Aaron Lindsay
Emilio, First, thanks for putting this together - I think everyone doing this sort of thing will benefit if we're able to agree on one upstream plugin interface. One thing I'd like to see is support for unregistering callbacks once they are registered. For instance, you can imagine that a plugin

[Qemu-devel] [RFC v2 05/38] plugin: add user-facing API

2018-12-09 Thread Emilio G. Cota
Add the API first to ease review. Signed-off-by: Emilio G. Cota --- include/qemu/qemu-plugin.h | 241 + 1 file changed, 241 insertions(+) create mode 100644 include/qemu/qemu-plugin.h diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h new f