Re: [Qemu-devel] [RFC v1 21/23] tcg: Add RISC-V cpu signal handler

2018-11-16 Thread Richard Henderson
On 11/15/18 11:37 PM, Alistair Francis wrote: > +/* Detect store by reading the instruction at the program > + counter. Note: we currently only generate 32-bit > + instructions so we thus only detect 32-bit stores */ Actually, you need to handle what the compiler generates too. So

Re: [Qemu-devel] [RFC v1 21/23] tcg: Add RISC-V cpu signal handler

2018-11-16 Thread Richard Henderson
On 11/15/18 11:37 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Signed-off-by: Michael Clark > --- > accel/tcg/user-exec.c | 48 +++ > 1 file changed, 48 insertions(+) Reviewed-by: Richard Henderson r~

[Qemu-devel] [RFC v1 21/23] tcg: Add RISC-V cpu signal handler

2018-11-15 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark --- accel/tcg/user-exec.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index cd75829cf2..bb693484ed 100644 --- a/accel/tcg/user-exec.c ++