Re: [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait

2018-06-13 Thread Eduardo Habkost
On Wed, Jun 13, 2018 at 09:22:10PM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2018 at 10:55:43AM +0200, Igor Mammedov wrote: > > On Tue, 12 Jun 2018 11:49:22 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, Jun 12, 2018 at 03:58:03PM +0200, Igor Mammedov wrote: > > > [...] > > > > > > >

Re: [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait

2018-06-13 Thread Michael S. Tsirkin
On Wed, Jun 13, 2018 at 10:55:43AM +0200, Igor Mammedov wrote: > On Tue, 12 Jun 2018 11:49:22 -0300 > Eduardo Habkost wrote: > > > On Tue, Jun 12, 2018 at 03:58:03PM +0200, Igor Mammedov wrote: > > [...] > > > > > > +if (xcc->host_cpuid_required && enable_cpu_pm) { > > > > > > +host_c

Re: [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait

2018-06-13 Thread Igor Mammedov
On Tue, 12 Jun 2018 11:49:22 -0300 Eduardo Habkost wrote: > On Tue, Jun 12, 2018 at 03:58:03PM +0200, Igor Mammedov wrote: > [...] > > > > > +if (xcc->host_cpuid_required && enable_cpu_pm) { > > > > > +host_cpuid(5, 0, &cpu->mwait.eax, &cpu->mwait.ebx, > > > > > + &c

Re: [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait

2018-06-12 Thread Eduardo Habkost
On Tue, Jun 12, 2018 at 03:58:03PM +0200, Igor Mammedov wrote: [...] > > > > +if (xcc->host_cpuid_required && enable_cpu_pm) { > > > > +host_cpuid(5, 0, &cpu->mwait.eax, &cpu->mwait.ebx, > > > > + &cpu->mwait.ecx, &cpu->mwait.edx); > > > > +} > > > could this sta

Re: [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait

2018-06-12 Thread Igor Mammedov
On Tue, 12 Jun 2018 15:57:19 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 12, 2018 at 02:56:05PM +0200, Igor Mammedov wrote: > > On Fri, 8 Jun 2018 23:59:19 +0300 > > "Michael S. Tsirkin" wrote: > > > > > When guest CPU PM is enabled, and with -cpu host, expose the host CPU > > > MWAIT lea

Re: [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait

2018-06-12 Thread Michael S. Tsirkin
On Tue, Jun 12, 2018 at 02:56:05PM +0200, Igor Mammedov wrote: > On Fri, 8 Jun 2018 23:59:19 +0300 > "Michael S. Tsirkin" wrote: > > > When guest CPU PM is enabled, and with -cpu host, expose the host CPU > > MWAIT leaf to guest so guest can make good PM decisions. > > > > Signed-off-by: Michael

Re: [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait

2018-06-12 Thread Igor Mammedov
On Fri, 8 Jun 2018 23:59:19 +0300 "Michael S. Tsirkin" wrote: > When guest CPU PM is enabled, and with -cpu host, expose the host CPU > MWAIT leaf to guest so guest can make good PM decisions. > > Signed-off-by: Michael S. Tsirkin > --- > > This builds but is untested. Is this a reasonable way

Re: [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait

2018-06-11 Thread Eduardo Habkost
On Fri, Jun 08, 2018 at 11:59:19PM +0300, Michael S. Tsirkin wrote: > When guest CPU PM is enabled, and with -cpu host, expose the host CPU > MWAIT leaf to guest so guest can make good PM decisions. > > Signed-off-by: Michael S. Tsirkin > --- > > This builds but is untested. Is this a reasonable

Re: [Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait

2018-06-08 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180608205830.308627-1-...@redhat.com Subject: [Qemu-devel] [RFC untested PATCH] i386

[Qemu-devel] [RFC untested PATCH] i386/cpu: make -cpu host support monitor/mwait

2018-06-08 Thread Michael S. Tsirkin
When guest CPU PM is enabled, and with -cpu host, expose the host CPU MWAIT leaf to guest so guest can make good PM decisions. Signed-off-by: Michael S. Tsirkin --- This builds but is untested. Is this a reasonable way to go about it? target/i386/cpu.h | 9 + target/i386/cpu.c | 18 ++