On 14/01/2015 11:06, Pavel Dovgaluk wrote:
>> > I think it is okay. INIT executes cpu_loop_exit() on x86 because
>> > processors other than the boot processor are halted after they receive
>> > INIT.
> Then I cannot put everything in one if-else chain because it will change the
> behavior of t
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> Bonzini
> On 14/01/2015 10:07, Pavel Dovgaluk wrote:
> >> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> >> On 12/01/2015 13:40, Pavel Dovgaluk wrote:
> >
> > Perhaps check the replay_interrupt() outside, in an
On 14/01/2015 10:07, Pavel Dovgaluk wrote:
>> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
>> On 12/01/2015 13:40, Pavel Dovgaluk wrote:
>
> Perhaps check the replay_interrupt() outside, in an && with "if
> (unlikely(interrupt_request))"?
>>> You mean that I should wrap whole cond
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> On 12/01/2015 13:40, Pavel Dovgaluk wrote:
> >>>
> >> > Perhaps check the replay_interrupt() outside, in an && with "if
> >> > (unlikely(interrupt_request))"?
> > You mean that I should wrap whole condition into "unlikely"?
> >
>
> No, I wanted
On 12/01/2015 13:40, Pavel Dovgaluk wrote:
>>>
>>> +if (replay_exception()) {
>>> +cc->do_interrupt(cpu);
>>> +cpu->exception_index = -1;
>>
>> I cannot see replay_exception() in the series?
>
> It is in the patch number 8.
Oop
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> On 12/01/2015 13:00, Pavel Dovgalyuk wrote:
> >
> > +if (replay_exception()) {
> > +cc->do_interrupt(cpu);
> > +cpu->exception_index = -1;
>
> I cannot see replay_exception() in
On 12/01/2015 13:00, Pavel Dovgalyuk wrote:
>
> +if (replay_exception()) {
> +cc->do_interrupt(cpu);
> +cpu->exception_index = -1;
I cannot see replay_exception() in the series?
> @@ -419,21 +434,24 @@ int cpu_exec(CPUArchStat
This patch includes modifications of common cpu files. All interrupts and
exceptions occured during recording are written into the replay log.
These events allow correct replaying the execution by kicking cpu thread
when one of these events is found in the log.
Signed-off-by: Pavel Dovgalyuk
---
