Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-06 Thread KONRAD Frédéric
On 06/12/2012 15:21, Peter Maydell wrote: On 6 December 2012 13:58, KONRAD Frédéric wrote: On 06/12/2012 11:13, Peter Maydell wrote: It can't just be a command line alias, or we will break migration. It has to be a simple device that composes together the virtio-pci and virtio-blk devices, plu

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-06 Thread Peter Maydell
On 6 December 2012 13:58, KONRAD Frédéric wrote: > On 06/12/2012 11:13, Peter Maydell wrote: >> It can't just be a command line alias, or we will break migration. >> It has to be a simple device that composes together the virtio-pci >> and virtio-blk devices, plus legacy support for properties and

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-06 Thread KONRAD Frédéric
On 06/12/2012 11:13, Peter Maydell wrote: On 6 December 2012 09:53, Andreas Färber wrote: Am 06.12.2012 10:21, schrieb KONRAD Frédéric: I agree with that, but, there is an issue : The refactored VirtIOBlk is a device and seems to work, but the device which use this VirtIOBlock (eg virtio-blk-p

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-06 Thread Peter Maydell
On 6 December 2012 09:53, Andreas Färber wrote: > Am 06.12.2012 10:21, schrieb KONRAD Frédéric: >> I agree with that, but, there is an issue : >> The refactored VirtIOBlk is a device and seems to work, but the device >> which use this VirtIOBlock >> (eg virtio-blk-pci) are just allocating a struct

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-06 Thread KONRAD Frédéric
On 06/12/2012 10:53, Andreas Färber wrote: Am 06.12.2012 10:21, schrieb KONRAD Frédéric: On 05/12/2012 18:22, Andreas Färber wrote: Am 05.12.2012 17:25, schrieb Peter Maydell: On 4 December 2012 14:35, wrote: From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can b

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-06 Thread Andreas Färber
Am 06.12.2012 10:21, schrieb KONRAD Frédéric: > On 05/12/2012 18:22, Andreas Färber wrote: >> Am 05.12.2012 17:25, schrieb Peter Maydell: >>> On 4 December 2012 14:35, wrote: From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on v

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-06 Thread KONRAD Frédéric
On 06/12/2012 10:18, Andreas Färber wrote: Am 06.12.2012 10:11, schrieb KONRAD Frédéric: On 05/12/2012 17:25, Peter Maydell wrote: On 4 December 2012 14:35, wrote: -static VirtIOBlock *to_virtio_blk(VirtIODevice *vdev) -{ -return (VirtIOBlock *)vdev; -} +/* + * Use the QOM cast, so we do

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-06 Thread KONRAD Frédéric
On 05/12/2012 18:22, Andreas Färber wrote: Am 05.12.2012 17:25, schrieb Peter Maydell: On 4 December 2012 14:35, wrote: From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 170 +++

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-06 Thread Andreas Färber
Am 06.12.2012 10:11, schrieb KONRAD Frédéric: > On 05/12/2012 17:25, Peter Maydell wrote: >> On 4 December 2012 14:35, wrote: >>> -static VirtIOBlock *to_virtio_blk(VirtIODevice *vdev) >>> -{ >>> -return (VirtIOBlock *)vdev; >>> -} >>> +/* >>> + * Use the QOM cast, so we don't need that anymo

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-06 Thread KONRAD Frédéric
On 05/12/2012 17:25, Peter Maydell wrote: On 4 December 2012 14:35, wrote: From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 170 -

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-05 Thread Andreas Färber
Am 05.12.2012 17:25, schrieb Peter Maydell: > On 4 December 2012 14:35, wrote: >> From: KONRAD Frederic >> >> Create virtio-blk which extends virtio-device, so it can be connected on >> virtio-bus. >> >> Signed-off-by: KONRAD Frederic >> --- >> hw/virtio-blk.c | 170 >> +++

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-05 Thread Peter Maydell
On 4 December 2012 14:35, wrote: > From: KONRAD Frederic > > Create virtio-blk which extends virtio-device, so it can be connected on > virtio-bus. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-blk.c | 170 > > hw/virtio-blk.h |

[Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-04 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 170 hw/virtio-blk.h | 4 ++ 2 files changed, 150 insertions(+), 24 deletio