On 11 September 2013 11:37, Gerd Hoffmann wrote:
>> What is the num_pages field supposed to mean, given that
>> "page size" isn't a well defined platform independent value
>> (for hardware or for QEMU)?
>
> It's 4k on x86 and not really defined on !x86 (with the !x86 installed
> base being pretty
> > (3) rom->num_pages field. That one will change for arm. The linux
> > kernel qxl kms driver seems not to care at all. Not surprising,
> > it is more convenient to use the offsets in the rom to figure how
> > the qxl memory layout looks like.
>
> Note that the ARM Linux *kern
On 11 September 2013 09:56, Gerd Hoffmann wrote:
> On Mi, 2013-09-11 at 09:20 +0100, Peter Maydell wrote:
>> Does this mean that the code was previously wrong for targets
>> which didn't have 4K pages, or would we just have been a bit
>> inefficient? I ask because ARM's TARGET_PAGE_SIZE is 1K...
>
On Mi, 2013-09-11 at 09:20 +0100, Peter Maydell wrote:
> On 11 September 2013 09:01, Gerd Hoffmann wrote:
> > On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote:
> >> It looks like TARGET_PAGE_SIZE is the only reason why qxl is built
> >> per-target, and in qxl_ram_set_dirty it should be enough
Il 11/09/2013 10:35, Fam Zheng ha scritto:
>> > Since you'll have a v6, please move "all: modules" to Makefile, and in
>> > rules.mak:
>> >
>> > .PHONY: modules
>> > modules:
>> >
> Why is ".PHONY: modules" not in Makefile too?
I think you would need it even in Makefile.target, so I suggested ru
On Wed, 09/11 09:27, Paolo Bonzini wrote:
> Il 11/09/2013 07:38, Fam Zheng ha scritto:
> > The new option will enable support of shared object build. Otherwise
> > objects are static linked to executables.
> >
> > Signed-off-by: Fam Zheng
> > ---
> > Makefile.target | 6 +-
> > configure
On 11 September 2013 09:01, Gerd Hoffmann wrote:
> On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote:
>> It looks like TARGET_PAGE_SIZE is the only reason why qxl is built
>> per-target, and in qxl_ram_set_dirty it should be enough to do
>>
>> qxl_set_dirty(&qxl->vga.vram, offset, offset +
On Wed, 09/11 10:01, Gerd Hoffmann wrote:
> On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote:
> > Il 11/09/2013 09:27, Paolo Bonzini ha scritto:
> > >
> > > There are a couple of things that can be improved still (I don't like
> > > obj-save-y for example), but things are taking shape and all
On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote:
> Il 11/09/2013 09:27, Paolo Bonzini ha scritto:
> >
> > There are a couple of things that can be improved still (I don't like
> > obj-save-y for example), but things are taking shape and all of this
> > looks like something that can be fixed
Il 11/09/2013 09:27, Paolo Bonzini ha scritto:
>
> There are a couple of things that can be improved still (I don't like
> obj-save-y for example), but things are taking shape and all of this
> looks like something that can be fixed on top. If you look at
> converting more parts to modules (e.g.
Il 11/09/2013 07:38, Fam Zheng ha scritto:
> The new option will enable support of shared object build. Otherwise
> objects are static linked to executables.
>
> Signed-off-by: Fam Zheng
> ---
> Makefile.target | 6 +-
> configure | 8
> rules.mak | 8 ++--
> 3 files
The new option will enable support of shared object build. Otherwise
objects are static linked to executables.
Signed-off-by: Fam Zheng
---
Makefile.target | 6 +-
configure | 8
rules.mak | 8 ++--
3 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/Make
12 matches
Mail list logo
