Re: [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate

2014-07-31 Thread Paolo Bonzini
Il 31/07/2014 17:49, Pavel Dovgalyuk ha scritto: > We cannot calculate timers in post_load, because it requires correct > value of virtual clock. And at that moment replay data structures could > be not loaded yet. Then this patch (and similarly others in this early part of the series) should be p

Re: [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate

2014-07-31 Thread Eric Blake
[meta-comment] On 07/31/2014 09:49 AM, Pavel Dovgalyuk wrote: > We cannot calculate timers in post_load, because it requires correct value of > virtual clock. And at that moment replay data structures could be not loaded > yet. > > > Sent from mobile device Your mobile device is breaking thre

Re: [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate

2014-07-31 Thread Pavel Dovgalyuk
We cannot calculate timers in post_load, because it requires correct value of virtual clock. And at that moment replay data structures could be not loaded yet. Sent from mobile device Исходное сообщение От: Paolo Bonzini Дата:31.07.2014 18:14 (GMT+04:00) Кому: Pavel Do

Re: [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate

2014-07-31 Thread Paolo Bonzini
Il 31/07/2014 14:54, Pavel Dovgalyuk ha scritto: > +static bool rtl8139_TimerExpire_needed(void *opaque) > +{ > +RTL8139State *s = (RTL8139State *)opaque; > +return s->TimerExpire != 0; > +} > + > +static const VMStateDescription vmstate_rtl8139_TimerExpire = { > +.name = "rtl8139/Timer

[Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate

2014-07-31 Thread Pavel Dovgalyuk
This patch adds virtual clock-dependent timers to VMState to allow correct saving and restoring the state of RTL8139 network controller. Signed-off-by: Pavel Dovgalyuk --- hw/net/rtl8139.c | 50 -- 1 files changed, 48 insertions(+), 2 deletions(-