On Wed, Apr 4, 2012 at 2:23 PM, Ori Mamluk wrote:
> Hi Stephan,
> Thanks again for the thorough and detailed review.
> Some answers embedded below, generally I took all the points you mentioned.
> Main changes were:
> - Use qemu-thread
> * WRT to this - I didn't find any recv() function there.
On 04/01/2012 06:05 AM, Ori Mamluk wrote:
> Repagent is a new block driver that allows an external replication system
> to hook to the Qemu storage stack to replicate a volume of a VM.
> This RFC patch adds the repagent client module to Qemu.
>
Completely non-technical review of just your documen
On Sun, Apr 01, 2012 at 03:05:48PM +0300, Ori Mamluk wrote:
Feedback on specific points below. The main thing to think about is how
to integrate with QEMU's event loop. You have used threads in places
but are also using qemu_set_fd_handler(). Most of QEMU's functions
(including the block layer)
