Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:42 PM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> This is a boiler-plate _nofail variant of qemu_opts_create. Remove and >> use error_abort in call sites. >> >> A null argument needs to be added for the id field in affected callsites >> due to inconsistency

Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Markus Armbruster
Peter Crosthwaite writes: > On Tue, Dec 3, 2013 at 7:42 PM, Markus Armbruster wrote: >> Peter Crosthwaite writes: [...] >>> @@ -3376,8 +3377,9 @@ int main(int argc, char **argv, char **envp) >>> } >>> >>> qemu_opt_set_bool(fsdev, "readonly", >>> -

Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:42 PM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> This is a boiler-plate _nofail variant of qemu_opts_create. Remove and >> use error_abort in call sites. >> >> A null argument needs to be added for the id field in affected callsites >> due to inconsistency

Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Markus Armbruster
Peter Crosthwaite writes: > This is a boiler-plate _nofail variant of qemu_opts_create. Remove and > use error_abort in call sites. > > A null argument needs to be added for the id field in affected callsites > due to inconsistency between the normal and no_fail variants. Two arguments, actually

[Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-02 Thread Peter Crosthwaite
This is a boiler-plate _nofail variant of qemu_opts_create. Remove and use error_abort in call sites. A null argument needs to be added for the id field in affected callsites due to inconsistency between the normal and no_fail variants. Signed-off-by: Peter Crosthwaite --- block/blkdebug.c