Re: [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking

2016-04-06 Thread Vijay Kilari
On Tue, Apr 5, 2016 at 8:06 PM, Peter Maydell wrote: > On 4 April 2016 at 14:39, wrote: >> From: Vijay >> >> Use Neon instructions to perform zero checking of >> buffer. This is helps in reducing downtime during >> live migration. >> >> Signed-off-by: Vijaya Kumar K >> --- >> util/cutils.c |

Re: [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking

2016-04-05 Thread Peter Maydell
On 5 April 2016 at 16:21, Paolo Bonzini wrote: > But in theory it should be enough to add a new #elif branch like this: > > #include "arm_neon.h" > #define VECTYPE uint64x2_t > #define VEC_OR(a, b) ((a) | (b)) > #define ALL_EQ(a, b) /* ??? :) */ #define ALL_EQ(a, b) (vgetq_lane_u64(a, 0) == vge

Re: [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking

2016-04-05 Thread Peter Maydell
On 4 April 2016 at 14:39, wrote: > From: Vijay > > Use Neon instructions to perform zero checking of > buffer. This is helps in reducing downtime during > live migration. One other comment I forgot: > +#define NEON_VECTYPE uint64x2_t This is a 128-bit type... > +static size_t b

Re: [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking

2016-04-05 Thread Paolo Bonzini
On 05/04/2016 16:36, Peter Maydell wrote: >> > + >> > +#define BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR_NEON 16 >> > + >> > +/* >> > + * Zero page/buffer checking using SIMD(Neon) >> > + */ >> > + >> > +static bool >> > +can_use_buffer_find_nonzero_offset_neon(const void *buf, size_t len) >> > +{

Re: [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking

2016-04-05 Thread Peter Maydell
On 4 April 2016 at 14:39, wrote: > From: Vijay > > Use Neon instructions to perform zero checking of > buffer. This is helps in reducing downtime during > live migration. > > Signed-off-by: Vijaya Kumar K > --- > util/cutils.c | 81 > +

[Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking

2016-04-04 Thread vijayak
From: Vijay Use Neon instructions to perform zero checking of buffer. This is helps in reducing downtime during live migration. Signed-off-by: Vijaya Kumar K --- util/cutils.c | 81 + 1 file changed, 81 insertions(+) diff --git a/util/