Re: [Qemu-devel] [RFC PATCH v1] iov: Factor out hexdumper

2013-02-07 Thread Peter Crosthwaite
On Thu, Feb 7, 2013 at 6:56 PM, Stefan Hajnoczi wrote: > On Thu, Feb 07, 2013 at 04:22:02PM +1000, Peter Crosthwaite wrote: >> diff --git a/util/hexdump.c b/util/hexdump.c >> new file mode 100644 >> index 000..38d64ca >> --- /dev/null >> +++ b/util/hexdump.c >> @@ -0,0 +1,23 @@ > > License/cop

Re: [Qemu-devel] [RFC PATCH v1] iov: Factor out hexdumper

2013-02-07 Thread Stefan Hajnoczi
On Thu, Feb 07, 2013 at 04:22:02PM +1000, Peter Crosthwaite wrote: > diff --git a/util/hexdump.c b/util/hexdump.c > new file mode 100644 > index 000..38d64ca > --- /dev/null > +++ b/util/hexdump.c > @@ -0,0 +1,23 @@ License/copyright header missing. Looks good otherwise. Stefan

[Qemu-devel] [RFC PATCH v1] iov: Factor out hexdumper

2013-02-06 Thread Peter Crosthwaite
Factor out the hexdumper functionality from iov for all to use. Useful for creating verbose debug printfery that dumps packet data. Signed-off-by: Peter Crosthwaite --- See v9 of the pl330 series for example usage. include/qemu/hexdump.h |3 +++ util/Makefile.objs |1 + util/hexdump