Re: [Qemu-devel] [RFC PATCH 6/9] blkdebug: Implement .cancel_async

2014-08-21 Thread Fam Zheng
On Thu, 08/21 17:52, Stefan Hajnoczi wrote: > On Thu, Aug 21, 2014 at 07:56:53PM +0800, Fam Zheng wrote: > > @@ -446,12 +439,25 @@ static void error_callback_bh(void *opaque) > > qemu_aio_release(acb); > > } > > > > +static void blkdebug_aio_cancel_async(BlockDriverAIOCB *blockacb) > > +{ >

Re: [Qemu-devel] [RFC PATCH 6/9] blkdebug: Implement .cancel_async

2014-08-21 Thread Stefan Hajnoczi
On Thu, Aug 21, 2014 at 07:56:53PM +0800, Fam Zheng wrote: > @@ -446,12 +439,25 @@ static void error_callback_bh(void *opaque) > qemu_aio_release(acb); > } > > +static void blkdebug_aio_cancel_async(BlockDriverAIOCB *blockacb) > +{ > +BlkdebugAIOCB *acb = container_of(blockacb, Blkdebug

[Qemu-devel] [RFC PATCH 6/9] blkdebug: Implement .cancel_async

2014-08-21 Thread Fam Zheng
Very similar to .cancel, except that cb is called before releasing the aio. Signed-off-by: Fam Zheng --- block/blkdebug.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 1586ed9..d269956 100644 --- a/block/blkdeb