Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Kevin Wolf
On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > This is preliminary and beta support for the VHDX image format, > as specified in: >"VHDX Format Specification v0.95", published 4/12/2012 > https://www.microsoft.com/en-us/download/details.aspx?id=29681 > > This RFC patch has th

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Jeff Cody
On Tue, Feb 19, 2013 at 03:57:53PM +0100, Kevin Wolf wrote: > On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > > This is preliminary and beta support for the VHDX image format, > > as specified in: > >"VHDX Format Specification v0.95", published 4/12/2012 > > https://www.microso

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Kevin Wolf
On Tue, Feb 19, 2013 at 10:04:07AM -0500, Jeff Cody wrote: > On Tue, Feb 19, 2013 at 03:30:10PM +0100, Kevin Wolf wrote: > > The whole point of packed structs is to enable the unaligned data > > access, so yes, you're right with that. But in my opinion declaring the > > struct packed and letting th

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Jeff Cody
On Tue, Feb 19, 2013 at 03:30:10PM +0100, Kevin Wolf wrote: > On Tue, Feb 19, 2013 at 08:26:35AM -0500, Jeff Cody wrote: > > On Tue, Feb 19, 2013 at 10:20:40AM +0100, Stefan Hajnoczi wrote: > > > On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > > > > +#include "qemu/crc32c.h" > > > > +#

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Kevin Wolf
On Tue, Feb 19, 2013 at 08:26:35AM -0500, Jeff Cody wrote: > On Tue, Feb 19, 2013 at 10:20:40AM +0100, Stefan Hajnoczi wrote: > > On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > > > +#include "qemu/crc32c.h" > > > +#include "block/vhdx.h" > > > + > > > +#define vhdx_nop(x) do { (void)(

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Jeff Cody
On Tue, Feb 19, 2013 at 10:20:40AM +0100, Stefan Hajnoczi wrote: > On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > > This is preliminary and beta support for the VHDX image format, > > as specified in: > >"VHDX Format Specification v0.95", published 4/12/2012 > > https://www.mi

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Stefan Hajnoczi
On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > This is preliminary and beta support for the VHDX image format, > as specified in: >"VHDX Format Specification v0.95", published 4/12/2012 > https://www.microsoft.com/en-us/download/details.aspx?id=29681 > > This RFC patch has th

[Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-18 Thread Jeff Cody
This is preliminary and beta support for the VHDX image format, as specified in: "VHDX Format Specification v0.95", published 4/12/2012 https://www.microsoft.com/en-us/download/details.aspx?id=29681 This RFC patch has the following limitations - read-only (no write support yet) - do