Re: [Qemu-devel] [RFC PATCH 16/41] block: Add error parameter to blk_insert_bs()

2017-02-20 Thread Max Reitz
On 20.02.2017 12:22, Kevin Wolf wrote: > Am 20.02.2017 um 12:04 hat Max Reitz geschrieben: >> On 13.02.2017 18:22, Kevin Wolf wrote: >>> Mow that blk_insert_bs() requests the BlockBackend permissions for the >>> node it attaches to, it can fail. Instead of aborting, pass the errors >>> to the calle

Re: [Qemu-devel] [RFC PATCH 16/41] block: Add error parameter to blk_insert_bs()

2017-02-20 Thread Kevin Wolf
Am 20.02.2017 um 12:04 hat Max Reitz geschrieben: > On 13.02.2017 18:22, Kevin Wolf wrote: > > Mow that blk_insert_bs() requests the BlockBackend permissions for the > > node it attaches to, it can fail. Instead of aborting, pass the errors > > to the callers. > > So it does qualify as a FIXME, bu

Re: [Qemu-devel] [RFC PATCH 16/41] block: Add error parameter to blk_insert_bs()

2017-02-20 Thread Max Reitz
On 13.02.2017 18:22, Kevin Wolf wrote: > Mow that blk_insert_bs() requests the BlockBackend permissions for the > node it attaches to, it can fail. Instead of aborting, pass the errors > to the callers. So it does qualify as a FIXME, but just for a single patch. Good. :-) > Signed-off-by: Kevin W

Re: [Qemu-devel] [RFC PATCH 16/41] block: Add error parameter to blk_insert_bs()

2017-02-13 Thread Fam Zheng
On Mon, 02/13 18:22, Kevin Wolf wrote: > Mow that blk_insert_bs() requests the BlockBackend permissions for the Now? :) > node it attaches to, it can fail. Instead of aborting, pass the errors > to the callers. > [snip] > @@ -332,11 +348,17 @@ int bdrv_commit(BlockDriverState *bs) > > /

[Qemu-devel] [RFC PATCH 16/41] block: Add error parameter to blk_insert_bs()

2017-02-13 Thread Kevin Wolf
Mow that blk_insert_bs() requests the BlockBackend permissions for the node it attaches to, it can fail. Instead of aborting, pass the errors to the callers. Signed-off-by: Kevin Wolf --- block/backup.c | 5 - block/block-backend.c| 12 block/commi