Re: [Qemu-devel] [RFC PATCH 14/21] trace: add support for plugin infrastructure

2018-10-15 Thread Richard Henderson
On 10/5/18 8:49 AM, Alex Bennée wrote: > +g_module = g_module_open(filename, > +G_MODULE_BIND_LAZY | G_MODULE_BIND_LOCAL); Do you really want lazy binding? It means that if a symbol is missing you won't see it here at load time. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC PATCH 14/21] trace: add support for plugin infrastructure

2018-10-06 Thread Emilio G. Cota
On Fri, Oct 05, 2018 at 16:49:03 +0100, Alex Bennée wrote: (snip) > +static int bind_to_tracepoints(GModule *g_module, GPtrArray *events) > +{ > +int count = 0; > +TraceEventIter iter; > +TraceEvent *ev; > + > +trace_event_iter_init(&iter, "*"); > +while ((ev = trace_event_iter_

[Qemu-devel] [RFC PATCH 14/21] trace: add support for plugin infrastructure

2018-10-05 Thread Alex Bennée
From: Pavel Dovgalyuk This patch adds support for dynamically loaded plugins. Every plugin is a dynamic library with a set of optional exported functions that will be called from QEMU. Signed-off-by: Pavel Dovgalyuk [AJB: moved to using trace point API] Signed-off-by: Alex Bennée --- ajb -