Re: [Qemu-devel] [RFC PATCH 11/15] qdev: add qbus_set_hotplug_handler_generic()

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:20PM -0500, Michael Roth wrote: > Certain devices types, like memory/CPU, are now being handled using a > hotplug interface provided by a top-level MachineClass. Hotpluggable > host bridges are another such device where it makes sense to use a > machine-level hotplug h

Re: [Qemu-devel] [RFC PATCH 11/15] qdev: add qbus_set_hotplug_handler_generic()

2015-04-30 Thread Paolo Bonzini
On 29/04/2015 21:20, Michael Roth wrote: > void qbus_set_hotplug_handler(BusState *bus, DeviceState *handler, Error > **errp) > { > -qbus_set_hotplug_handler_internal(bus, OBJECT(handler), errp); > +qbus_set_hotplug_handler_generic(bus, OBJECT(handler), errp); > } > I think it's ok

[Qemu-devel] [RFC PATCH 11/15] qdev: add qbus_set_hotplug_handler_generic()

2015-04-29 Thread Michael Roth
Certain devices types, like memory/CPU, are now being handled using a hotplug interface provided by a top-level MachineClass. Hotpluggable host bridges are another such device where it makes sense to use a machine-level hotplug handler. However, unlike those devices, host-bridges have a parent bus