Re: [Qemu-devel] [RFC PATCH 11/13] hmp: add NBD server commands

2012-09-19 Thread Paolo Bonzini
Il 18/09/2012 22:22, Luiz Capitulino ha scritto: >> > +if (addr.host == NULL || addr.port == NULL) { >> > +error_set(&errp, QERR_SOCKET_CREATE_FAILED); > You can and should use monitor_printf() directly. Hmm, why? Then I would have two error paths, one with monitor_printf and one with

Re: [Qemu-devel] [RFC PATCH 11/13] hmp: add NBD server commands

2012-09-18 Thread Luiz Capitulino
On Mon, 27 Aug 2012 17:00:24 +0200 Paolo Bonzini wrote: > At the HMP level there is no nbd_server_add command. nbd_server_start > automatically exposes all of the VM's block devices, and an option -w > makes them writable. > > Signed-off-by: Paolo Bonzini > --- > hmp-commands.hx | 29

[Qemu-devel] [RFC PATCH 11/13] hmp: add NBD server commands

2012-08-27 Thread Paolo Bonzini
At the HMP level there is no nbd_server_add command. nbd_server_start automatically exposes all of the VM's block devices, and an option -w makes them writable. Signed-off-by: Paolo Bonzini --- hmp-commands.hx | 29 + hmp.c | 66