Re: [Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add option for io_uring

2019-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2019 at 06:21:51AM +0530, Aarushi Mehta wrote: > On Tue, 2019-05-21 at 19:39 -0500, Eric Blake wrote: > > On 5/21/19 6:52 PM, Aarushi Mehta wrote: > > > Signed-off-by: Aarushi Mehta > > > > Sparse on the details. The subject line says what, but without a > > 'why' > > for how io_u

Re: [Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add option for io_uring

2019-05-21 Thread Eric Blake
On 5/21/19 7:51 PM, Aarushi Mehta wrote: >>> +# @io_uring:Use linux io_uring >> >> Missing a '(since 4.1)' tag. >> >>> # >>> # Since: 2.9 >>> ## >>> { 'enum': 'BlockdevAioOptions', >>> - 'data': [ 'threads', 'native' ] } >>> + 'data': [ 'threads', 'native','io_uring' ] } >> >> Missing sp

Re: [Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add option for io_uring

2019-05-21 Thread Aarushi Mehta
On Tue, 2019-05-21 at 19:39 -0500, Eric Blake wrote: > On 5/21/19 6:52 PM, Aarushi Mehta wrote: > > Signed-off-by: Aarushi Mehta > > Sparse on the details. The subject line says what, but without a > 'why' > for how io_uring is different from existing aio options, it's hard to > see why I'd want

Re: [Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add option for io_uring

2019-05-21 Thread Eric Blake
On 5/21/19 6:52 PM, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta Sparse on the details. The subject line says what, but without a 'why' for how io_uring is different from existing aio options, it's hard to see why I'd want to use it. Do you have any benchmark numbers? > --- > qapi/block-

[Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add option for io_uring

2019-05-21 Thread Aarushi Mehta
Signed-off-by: Aarushi Mehta --- qapi/block-core.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 7ccbfff9d0..116995810a 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2776,11 +2776,12 @@ # # @threads: