Re: [Qemu-devel] [RFC PATCH 1/6] adlib: qdev-ify

2013-04-10 Thread Paolo Bonzini
Il 09/04/2013 19:28, Andreas Färber ha scritto: >> -int Adlib_init (ISABus *bus) >> +static int Adlib_initfn (ISADevice *dev) > > Hm, obviously that conflicts with my series converting ISADevices to QOM > realize that I was hoping to still get into 1.5... Just put this patch in front of your seri

Re: [Qemu-devel] [RFC PATCH 1/6] adlib: qdev-ify

2013-04-10 Thread Paolo Bonzini
Il 09/04/2013 19:28, Andreas Färber ha scritto: >> > +#ifdef HAS_YMF262 >> > +#define ADLIB_DESC "Yamaha YMF262 (OPL3)" >> > +#else >> > +#define ADLIB_DESC "Yamaha YM3812 (OPL2)" >> > +#endif > Shouldn't in the process of QOM'ifying this be split into two devices? > Is HAS_YMF262 user-selected or

Re: [Qemu-devel] [RFC PATCH 1/6] adlib: qdev-ify

2013-04-09 Thread Andreas Färber
Am 02.04.2013 16:50, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > hw/adlib.c | 82 > -- > 1 file changed, 64 insertions(+), 18 deletions(-) > > diff --git a/hw/adlib.c b/hw/adlib.c > index e6bce59..ca47b55 100644 > ---

[Qemu-devel] [RFC PATCH 1/6] adlib: qdev-ify

2013-04-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/adlib.c | 82 -- 1 file changed, 64 insertions(+), 18 deletions(-) diff --git a/hw/adlib.c b/hw/adlib.c index e6bce59..ca47b55 100644 --- a/hw/adlib.c +++ b/hw/adlib.c @@ -31,6 +31,12 @@ #define AD