Re: [Qemu-devel] [RFC PATCH 1/2] Un-inline fdctrl_init_isa()

2012-05-14 Thread Kevin Wolf
Am 14.05.2012 15:32, schrieb Anthony Liguori: > On 05/11/2012 10:22 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster > > Reviewed-by: Anthony Liguori > > I know this is a pervasive idiom, but it makes little sense to me and I've > got a > number of similar changes queued up mys

Re: [Qemu-devel] [RFC PATCH 1/2] Un-inline fdctrl_init_isa()

2012-05-14 Thread Anthony Liguori
On 05/11/2012 10:22 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori I know this is a pervasive idiom, but it makes little sense to me and I've got a number of similar changes queued up myself. Regards, Anthony Liguori --- hw/fdc.c | 20

[Qemu-devel] [RFC PATCH 1/2] Un-inline fdctrl_init_isa()

2012-05-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/fdc.c | 20 hw/fdc.h | 24 ++-- hw/ide/piix.c |3 ++- hw/isa.h |2 -- hw/pc_sysfw.c |1 + qemu-common.h |1 + 6 files changed, 26 insertions(+), 25 deletions(-) diff --git a/hw/fd