Re: [Qemu-devel] [RFC PATCH 01/16] Visitor: Add methods for migration format use

2014-06-06 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert (git)" writes: > >> > > > > Hi Markus, > > Thanks for the review. I've reordered your comments to group some of the > > replies

Re: [Qemu-devel] [RFC PATCH 01/16] Visitor: Add methods for migration format use

2014-06-06 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" writes: >> > > Hi Markus, > Thanks for the review. I've reordered your comments to group some of the > replies together. > >> > From: "Dr. David Alan Gilbert" > >> Your patch

Re: [Qemu-devel] [RFC PATCH 01/16] Visitor: Add methods for migration format use

2014-06-05 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > > Load/save flags to let a user perform pre-save/post-load checking > > > > Odd. I'd expect separate visitors, one for save, one

Re: [Qemu-devel] [RFC PATCH 01/16] Visitor: Add methods for migration format use

2014-06-05 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > Hi Markus, Thanks for the review. I've reordered your comments to group some of the replies together. > > From: "Dr. David Alan Gilbert" > Your patch drags migration-specific stuff into the until now

Re: [Qemu-devel] [RFC PATCH 01/16] Visitor: Add methods for migration format use

2014-06-05 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > array types > From https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg02465.html > > str256 type > For the upto 256byte strings QEMU commonly uses for IDs Naive question: why do you need this when you hav

[Qemu-devel] [RFC PATCH 01/16] Visitor: Add methods for migration format use

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" array types From https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg02465.html str256 type For the upto 256byte strings QEMU commonly uses for IDs buffer type For a blob of data that the caller wants to deliver whole (e.g. a page of RAM or b