Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-23 Thread Paolo Bonzini
On 20/04/2018 20:35, Emilio G. Cota wrote: > The executable is now larger: > > - before: >textdata bss dec hex filename > 9864951 2944592 4371560 1718110310629af > aarch64-softmmu/qemu-system-aarch64 > > - after: >textdata bss dec hex filename > 98

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Emilio G. Cota
On Fri, Apr 20, 2018 at 16:11:35 -0300, Philippe Mathieu-Daudé wrote: > On 04/20/2018 03:35 PM, Emilio G. Cota wrote: > > I also changed the patches to make the series simpler: one patch > > to add softmmu.c (without compiling it yet), one patch to > > actually use softmmu.c, and a final patch to r

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Alex Bennée
Emilio G. Cota writes: > On Fri, Apr 20, 2018 at 16:50:39 +0100, Alex Bennée wrote: >> Any questions/thoughts/comments? > > Very nice! > > I modified the style a little bit, namely to pass checkpatch and to > improve grepability by having > foo __attribute__((flatten)) > function(arg1, arg2,

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 03:35 PM, Emilio G. Cota wrote: > On Fri, Apr 20, 2018 at 16:50:39 +0100, Alex Bennée wrote: >> Any questions/thoughts/comments? > > Very nice! Yep :) > > I modified the style a little bit, namely to pass checkpatch and to > improve grepability by having > foo __attribute__((fla

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Alex Bennée
Awesome, thanks! On Fri, 20 Apr 2018, 19:35 Emilio G. Cota, wrote: > On Fri, Apr 20, 2018 at 16:50:39 +0100, Alex Bennée wrote: > > Any questions/thoughts/comments? > > Very nice! > > I modified the style a little bit, namely to pass checkpatch and to > improve grepability by having > foo __at

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Emilio G. Cota
On Fri, Apr 20, 2018 at 16:50:39 +0100, Alex Bennée wrote: > Any questions/thoughts/comments? Very nice! I modified the style a little bit, namely to pass checkpatch and to improve grepability by having foo __attribute__((flatten)) function(arg1, arg2, ...) as opposed to foo __attribute__((

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Peter Maydell
On 20 April 2018 at 16:50, Alex Bennée wrote: > accel/tcg/Makefile.objs | 1 + > accel/tcg/cputlb.c | 61 + > accel/tcg/cputlb.h | 20 ++ > accel/tcg/softmmu.c | 497 +++ > accel/tcg/softmmu_template.h | 435 ---

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Paolo Bonzini
On 20/04/2018 17:50, Alex Bennée wrote: > > Why go through all of this hassle? Some justifications: > > - no more "where is helper_le_stw_mmu defined?" > - easier debugging in gdb > - no duplicate code for be/le cases > - more accessible code > > I think there is also scope for more re-f

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180420155045.18862-1-alex.ben...@linaro.org Subject: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code === TEST SCRIPT BEGIN === #!/bin/bash BASE

[Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Alex Bennée
Hi, This is very much a Friday RFC patch but was born out of a chat I had with Richard at Connect about our experience in the re-factoring of softfloat. The basic premise is we shouldn't need to jump through macro/glue abuse for stuff a decent compiler should be able to dead code away at compile