Re: [Qemu-devel] [RFC PATCH 0/5] ui: add keyboard state and hotkey tracker

2018-02-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180221170820.15365-1-kra...@redhat.com Subject: [Qemu-devel] [RFC PATCH 0/5] ui: add keyboard state and hotkey tracker === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [RFC PATCH 0/5] ui: add keyboard state and hotkey tracker

2018-02-21 Thread Gerd Hoffmann
Ok, here is my alternative approach to hotkey configuration. Downside: It does *not* allow to freely choose any keys for hotkeys. Hotkeys are restricted to be one normal key combined with up to three modifiers (no modifiers is fine too). Upside: The code is simpler. We don't have to keep back e