Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-29 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Pavel Dovgalyuk writes: >> > One more question about your trace points. >> > In case of using trace point on every instruction execution, we may need >> > accessing vCPU registers (including the flags). Are they va

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-29 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > One more question about your trace points. > > In case of using trace point on every instruction execution, we may need > > accessing vCPU registers (including the flags). Are they valid in such > > cases? > > They

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-29 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Pavel Dovgalyuk writes: >> >> >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> >> Pavel Dovgalyuk writes: >> >> >> >> >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> >> >> Any serious analysis tool

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-29 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > >> From: Alex Bennée [mailto:alex.ben...@linaro.org] > >> Pavel Dovgalyuk writes: > >> > >> >> From: Alex Bennée [mailto:alex.ben...@linaro.org] > >> >> Any serious analysis tool should allow for us to track all me

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-09 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Pavel Dovgalyuk writes: >> >> >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> >> Any serious analysis tool should allow for us to track all memory >> >> accesses so I think the guest_mem_before trace point

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-09 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > >> From: Alex Bennée [mailto:alex.ben...@linaro.org] > >> Any serious analysis tool should allow for us to track all memory > >> accesses so I think the guest_mem_before trace point should probably > >> be split int

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-09 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Any serious analysis tool should allow for us to track all memory >> accesses so I think the guest_mem_before trace point should probably >> be split into guest_mem_before_store and guest_mem_after_load. We >> could

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-08 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Any serious analysis tool should allow for us to track all memory > accesses so I think the guest_mem_before trace point should probably > be split into guest_mem_before_store and guest_mem_after_load. We > could go the whole hog and add potenti

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-08 Thread Alex Bennée
Emilio G. Cota writes: > On Mon, Oct 08, 2018 at 11:28:38 +0100, Alex Bennée wrote: >> Emilio G. Cota writes: >> > Again, for performance you'd avoid the tracepoint (i.e. calling >> > a helper to call another function) and embed directly the >> > callback from TCG. Same thing applies to TB's.

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-08 Thread Emilio G. Cota
On Mon, Oct 08, 2018 at 11:28:38 +0100, Alex Bennée wrote: > Emilio G. Cota writes: > > Again, for performance you'd avoid the tracepoint (i.e. calling > > a helper to call another function) and embed directly the > > callback from TCG. Same thing applies to TB's. > > OK I see what you mean. I th

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-08 Thread Philippe Mathieu-Daudé
Hi Alex, On 08/10/2018 12:28, Alex Bennée wrote: > > Emilio G. Cota writes: > >> On Fri, Oct 05, 2018 at 16:48:49 +0100, Alex Bennée wrote: >> (snip) >>> ==Known Limitations== >>> >>> Currently there is only one hook allowed per trace event. We could >>> make this more flexible or simply just e

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-08 Thread Alex Bennée
Emilio G. Cota writes: > On Fri, Oct 05, 2018 at 16:48:49 +0100, Alex Bennée wrote: > (snip) >> ==Known Limitations== >> >> Currently there is only one hook allowed per trace event. We could >> make this more flexible or simply just error out if two plugins try >> and hook to the same point. Wh

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-06 Thread Emilio G. Cota
On Fri, Oct 05, 2018 at 16:48:49 +0100, Alex Bennée wrote: (snip) > ==Known Limitations== > > Currently there is only one hook allowed per trace event. We could > make this more flexible or simply just error out if two plugins try > and hook to the same point. What are the expectations of running

[Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-05 Thread Alex Bennée
Hi, This series is a combination of general clean-ups to logging and tracing and a RFC for extending the tracepoint API by the addition of plugins. An example usage would be: ./aarch64-linux-user/qemu-aarch64 -d plugin,nochain -plugin file=trace/plugins/hotblocks.so,args=5 ./aarch64-linux-user