Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-17 Thread Paolo Bonzini
On 16/08/2018 09:22, Zhoujian (jay) wrote: > Could we add the check !runstate_check(RUN_STATE_FINISH_MIGRATE) before > setting > to RUN_STATE_PRELAUNCH, just like !runstate_check(RUN_STATE_RUNNING) and > !runstate_check(RUN_STATE_INMIGRATE) did? But I'm not sure whether this will > cause any side

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 16/08/2018 09:22, Zhoujian (jay) wrote: > > Could we add the check !runstate_check(RUN_STATE_FINISH_MIGRATE) before > > setting > > to RUN_STATE_PRELAUNCH, just like !runstate_check(RUN_STATE_RUNNING) and > > !runstate_check(RUN_STATE_INMIGRATE) di

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-16 Thread Zhoujian (jay)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, August 14, 2018 9:07 PM > To: Zhoujian (jay) ; Dr. David Alan Gilbert > > Cc: qemu-devel@nongnu.org; quint...@redhat.com; wangxin (U) > > Subject: Re: [RFC PATCH] vl: fix migration when watchdog expir

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-14 Thread Zhoujian (jay)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, August 14, 2018 9:07 PM > To: Zhoujian (jay) ; Dr. David Alan Gilbert > > Cc: qemu-devel@nongnu.org; quint...@redhat.com; wangxin (U) > > Subject: Re: [RFC PATCH] vl: fix migration when watchdog expir

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-14 Thread Paolo Bonzini
On 14/08/2018 15:03, Zhoujian (jay) wrote: >> -Original Message- >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> Sent: Tuesday, August 14, 2018 8:02 PM >> To: Dr. David Alan Gilbert >> Cc: Zhoujian (jay) ; qemu-devel@nongnu.org; >> quint...@redhat.com; wangxin (U) >> Subject: Re: [

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-14 Thread Zhoujian (jay)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, August 14, 2018 8:02 PM > To: Dr. David Alan Gilbert > Cc: Zhoujian (jay) ; qemu-devel@nongnu.org; > quint...@redhat.com; wangxin (U) > Subject: Re: [RFC PATCH] vl: fix migration when watchdog expires

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-14 Thread Zhoujian (jay)
> -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Tuesday, August 14, 2018 7:52 PM > To: Paolo Bonzini > Cc: Zhoujian (jay) ; qemu-devel@nongnu.org; > quint...@redhat.com; wangxin (U) > Subject: Re: [RFC PATCH] vl: fix migration when watchdog expires

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-14 Thread Paolo Bonzini
On 14/08/2018 13:52, Dr. David Alan Gilbert wrote: > a) Should the watchdog expire when the VM is stopped; I think it > shouldn't - hw/acpi/tco.c uses a virtual timer as does i6300esb; so > is the bug here that the watchdog being used didn't use a virtual > timer? All watchdogs do. > b) If the

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-14 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 14/08/2018 12:48, Jay Zhou wrote: > > I got the following error when migrating a VM with watchdog > > device: > > > > {"timestamp": {"seconds": 1533884471, "microseconds": 668099}, > > "event": "WATCHDOG", "data": {"action": "reset"}} > > {"timesta

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-14 Thread Paolo Bonzini
On 14/08/2018 12:48, Jay Zhou wrote: > I got the following error when migrating a VM with watchdog > device: > > {"timestamp": {"seconds": 1533884471, "microseconds": 668099}, > "event": "WATCHDOG", "data": {"action": "reset"}} > {"timestamp": {"seconds": 1533884471, "microseconds": 677658}, > "ev

[Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-14 Thread Jay Zhou
I got the following error when migrating a VM with watchdog device: {"timestamp": {"seconds": 1533884471, "microseconds": 668099}, "event": "WATCHDOG", "data": {"action": "reset"}} {"timestamp": {"seconds": 1533884471, "microseconds": 677658}, "event": "RESET", "data": {"guest": true}} {"timestamp