Re: [Qemu-devel] [RFC PATCH] spapr_pci: make index property mandatory

2017-09-13 Thread David Gibson
On Mon, Sep 11, 2017 at 01:35:03PM +0200, Greg Kurz wrote: > Creating several PHBs without index property confuses the DRC code > and causes issues: > - only the first index-less PHB is functional, the other ones will > silently ignore hotplugging of PCI devices > - QEMU will even terminate if th

Re: [Qemu-devel] [RFC PATCH] spapr_pci: make index property mandatory

2017-09-11 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH] spapr_pci: make index property mandatory Message-id: 150512970330.16081.7553039475680302776.stgit@bahia Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE

[Qemu-devel] [RFC PATCH] spapr_pci: make index property mandatory

2017-09-11 Thread Greg Kurz
Creating several PHBs without index property confuses the DRC code and causes issues: - only the first index-less PHB is functional, the other ones will silently ignore hotplugging of PCI devices - QEMU will even terminate if these PHBs have cold-plugged devices qemu-system-ppc64: -device virtio